Repository navigation
Conversation
Signed-off-by: wdykas <wdykas@nvidia.com>
Signed-off-by: wdykas <wdykas@nvidia.com>
Contributor
Author
|
/ok to test 2153480 |
Contributor
Author
|
Closing in favor of #7303, which now includes these TE device-metadata batch-invariant training changes and their tests. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #7302. Opt in to TE device-metadata grouped GEMM for batch-invariant training using
moe_use_grouped_tensor=True, reusing the existing 256-row expert padding. Dense and legacy grouped GEMMs keep their restricted workspace.The grouped path needs the full workspace, with separate allocations for forward/dgrad/wgrad layouts. Restrict it to the numerically validated SM100 + cuBLASLt 13.5.1 combination and TE's
GroupedLinear(use_grouped_tensor=...)API. Other GPU/library pairs fail explicitly. Fixed-batch backward replay is tested; gradients across different minibatches are not promised to be identical.Also includes the isolated SwiGLU rounding fix pushed to #7302; that commit disappears from this diff when the base mirror updates.
Validation
atol=0, rtol=0). Each model checked 64 valid response tokens in both comparisons, including a second refit/rollout.Pinned test TE:
51317b440be0378f570ca6cc7dec2962f6e3f8df(2.20.0.dev0+51317b4), PyTorch 2.11.0+cu130, cuBLASLt 13.5.1. The full-model smoke tests use short eight-token responses, zero rewards and no model-level CUDA graphs; they are not convergence or throughput benchmarks. Kernel-level graphs are covered separately. NeMo RL integration fixes are onwdykas/RL:fix/minf-mxfp8-zero-logprob-parity.Existing base-PR CI is not claimed green: its logs include GDN config-default drift, an MLA optimizer assertion, and an M2N illegal access/timeout. The M2N test passes with the local pinned stack; the CI-environment difference remains to be isolated.