Repository navigation
Conversation
Signed-off-by: Tyler Poon <tpoon@nvidia.com>
Signed-off-by: Tyler Poon <tpoon@nvidia.com>
Contributor
Author
|
/ok to test ea7eee9 |
This was referenced Sep 11, 2026
Signed-off-by: Tyler Poon <tpoon@nvidia.com>
Contributor
Author
|
/ok to test c4ca837 |
This was referenced Sep 14, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Carry packed multimodal metadata through LLaVA, split/gather vision tokens for context parallelism, and handle padding and loss weighting consistently. Include model tests and single-writer dataloader checkpoint-state handling.
This is part of a review-split multimodal SFT series. Production run scripts, data YAMLs, checkpoint conversion tooling, and separate CI compatibility fixes are outside this series.
Dependencies and review scope
Stacked on #7249. Review the vision context-parallelism/metadata commits above that parent. The review base uses its bot-created mirror; retarget to
mainbefore merging.Validation
mainat46fb90ca942a2950c58c5654b3e56877e88a3e35, preserving atomic signed and signed-off commits.megatron/coreandtests). Mypy is unavailable locally. Changed Python files pass syntax parsing; no CI configuration changes are included.Kept as a draft pending CI and dependency integration.