Repository navigation
Enable async scheduling by default for dynamic inference - #6851
Merged
lmcafee-nvidia merged 7 commits intoAug 28, 2026
Merged
Conversation
Signed-off-by: Lawrence McAfee <lmcafee@nvidia.com>
Signed-off-by: Lawrence McAfee <lmcafee@nvidia.com>
Signed-off-by: Lawrence McAfee <lmcafee@nvidia.com>
kvareddy
approved these changes
Aug 25, 2026
shanmugamr1992
approved these changes
Aug 25, 2026
cuichenx
approved these changes
Aug 27, 2026
jaredcasper
approved these changes
Aug 27, 2026
…bled Signed-off-by: Lawrence McAfee <lmcafee@nvidia.com> # Conflicts: # tests/unit_tests/inference/engines/test_dynamic_engine.py # tests/unit_tests/inference/test_inference_config.py
Contributor
Author
|
/ok to test 7969663 |
Signed-off-by: Lawrence McAfee <lmcafee@nvidia.com>
Contributor
Author
|
/ok to test 18ede66 |
Signed-off-by: Lawrence McAfee <lmcafee@nvidia.com>
Contributor
Author
|
/ok to test 3624de3 |
Signed-off-by: Lawrence McAfee <lmcafee@nvidia.com>
Contributor
Author
|
/ok to test e10b2bd |
Contributor
Author
|
CI follow-up:
|
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/33200833723 |
ksivaman
pushed a commit
to ksivaman/Megatron-LM
that referenced
this pull request
Sep 1, 2026
Signed-off-by: Lawrence McAfee <lmcafee@nvidia.com>
This was referenced Oct 12, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable async scheduling by default for dynamic batching inference while retaining an explicit legacy opt-out.
Issue tracking
Linked issue: N/A
Changes
legacytoasync.--inference-dynamic-batching-async-sched-mode legacyas the explicit opt-out.Validation
16597287: targeted async-default dynamic-engine tests passed on all eight ranks, 23 tests per rank.16593806: targeted inference unit tests, 25 passed.16593984: default-async functional golden comparison passed withasync_sched_step_count=30.16593808: both routing-replay compatibility recipes passed.16593809: legacy and async performance matrices passed all baseline tolerances.16592143: focused config tests passed on all eight ranks, 37 tests per rank.tools/autoformat.sh, Ruff, Python syntax, shell syntax, YAML parsing, andgit diff --checkpassed.An additional broad inference sweep in job
16592143later encountered failures in explicitly legacy FP8 cases followed by a GDN pipeline NCCL timeout; those paths do not exercise the changed default. The initial functional job16593807exposed the zero-prefill timing issue fixed here, and its rerun passed as noted above.Contribution process
Pre-checks
tools/autoformat.shon my PR