Skip to content

Add option to run MIMO input projections on LLM ranks - #6843

Merged
chtruong814 merged 3 commits into
NVIDIA:mainfrom
yashaswikarnati:codex/mimo-language-input-projections-public
Sep 18, 2026
Merged

chtruong814 merged 3 commits into
NVIDIA:mainfrom
yashaswikarnati:codex/mimo-language-input-projections-public

Conversation

@yashaswikarnati

@yashaswikarnati yashaswikarnati commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • optionally place MIMO modality input projections on the first LLM rank with --mimo-run-input-projections-on-llm-ranks
  • preserve raw bridge payloads while keeping canonical checkpoint keys independent of projector placement
  • handle frozen encoders and projector ranks that receive zero local tokens
  • avoid tensor truth-value conversion while assembling the global MIMO gradient norm

Validation

  • CW-DFW 16634648 (8 GPUs): the exact models-bucket optimizer fixture regression, frozen-encoder language-rank BF16 optimizer step, and world-consensus test passed on ranks 0-7
  • CW-DFW 16634875: Black and isort checks passed on the final files
  • CW-DFW 16633675 (8 GPUs): frozen-encoder language-rank BF16 optimizer step and world-consensus tests passed
  • CW-DFW 16627732 (8 GPUs): renamed parser flag, validation, and provider placement tests passed
  • CW-DFW 16627995 (8 GPUs): exact 20L checkpoint save/load/resave round trip passed with the renamed flag
  • CW-DFW 16616723 (8 GPUs): empty source payload, frozen-encoder language-rank projection, and real zero-token GTP forward/backward tests passed
  • CW-DFW 16606559 (8 GPUs): 23 focused parser, construction, freeze/DDP, quantization, empty-payload, and schedule tests passed
  • CW-DFW 16606666 (8 GPUs, GTP-enabled): zero-token projector forward/backward and cross-placement checkpoint loading in both directions passed
  • CW-DFW 16568629 / 16568652: functional checkpoint round trips passed with language-rank and encoder-rank projection placement
  • GitHub linting, Pip/UV install, wheel build/test, docs, and release checks passed on the preceding head; its models bucket had one stale fake-module fixture failure, fixed and rerun in 16634648
  • isort --check-only, ruff check, compileall, and git diff --check passed

@copy-pr-bot

copy-pr-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yashaswikarnati
yashaswikarnati force-pushed the codex/mimo-language-input-projections-public branch from eb7b2ef to c0f9329 Compare August 25, 2026 08:43
@copy-pr-bot

copy-pr-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@yashaswikarnati
yashaswikarnati force-pushed the codex/mimo-language-input-projections-public branch 2 times, most recently from 687789c to 4627c10 Compare August 25, 2026 19:41
@sancha
sancha marked this pull request as ready for review August 25, 2026 20:53
@sancha
sancha requested review from a team as code owners August 25, 2026 20:53
module_sd = sharded_state_dict_default(
inner, child_prefix, sharded_offsets, mod_metadata
)
if (

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this change so we can still load checkpoints indepedent of if projection layers are used on llm ranks

@yashaswikarnati
yashaswikarnati marked this pull request as ready for review August 25, 2026 21:45
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Aug 25, 2026
@deepakn94 deepakn94 changed the title Option to run MIMO input projections on LLM ranks Add option to run MIMO input projections on LLM ranks Aug 26, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Aug 26, 2026
@yashaswikarnati
yashaswikarnati force-pushed the codex/mimo-language-input-projections-public branch from 0f56e81 to afc1b15 Compare August 27, 2026 22:05
@yashaswikarnati

Copy link
Copy Markdown
Contributor Author

/ok to test afc1b15

@yashaswikarnati

Copy link
Copy Markdown
Contributor Author

/ok to test 261ed6f

@nemo-automation-bot

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/33340891254

Signed-off-by: ykarnati <ykarnati@nvidia.com>
@yashaswikarnati

Copy link
Copy Markdown
Contributor Author

/ok to test e788d04

@jaredcasper jaredcasper mentioned this pull request Sep 16, 2026
1 of 7 tasks
@jaredcasper

Copy link
Copy Markdown
Contributor

/ok to test 4f02449

@jaredcasper

Copy link
Copy Markdown
Contributor

/ok to test 9cd934e

@nemo-automation-bot

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/35283996265

@chtruong814

Copy link
Copy Markdown
Contributor

Ran CI as part of an aggregated branch that included multiple PRs in the queue.
#7459

CI passed
https://github.com/NVIDIA/Megatron-LM/actions/runs/35291473099?pr=7459

Will fast merge this

@nemo-automation-bot

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/35302229442

This branch was previously deployed

2 inactive deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants