Repository navigation
Conversation
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
svcnvidia-nemo-ci
marked this pull request as draft
August 20, 2026 17:40
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
JF-D
marked this pull request as ready for review
August 20, 2026 17:41
Open
JF-D
force-pushed
the
jiangfeid/cg_persistent_buffer_fix
branch
from
August 24, 2026 18:37
6e2a660 to
d07354c
Compare
Contributor
Author
|
/claude strict-review |
Contributor
Author
|
@claude strict-review |
Contributor
Author
|
/claude review |
Signed-off-by: Jiangfei Duan <jiangfeid@nvidia.com>
JF-D
force-pushed
the
jiangfeid/cg_persistent_buffer_fix
branch
from
August 24, 2026 22:55
d07354c to
cc5af1f
Compare
Member
|
/claude strict-review |
fanshiqing
reviewed
Aug 25, 2026
Contributor
Author
This was referenced Aug 27, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Generalizes fixed-address persistent storage for GTP backward operations captured by local CUDA graphs. It also enables NCCL symmetric-memory one-shot reduce-scatter for GTP + local CUDA graphs.
Problem
Local CUDA graph replay requires every graph-owned communication buffer to retain a stable address. The existing specialized wgrad-ring mechanism has several limitations:
Consequently, adding another graph-owned GTP tensor requires another specialized lifetime mechanism, while symmetric one-shot RS cannot safely reuse ordinary graph storage.
Solution
This PR replaces the specialized wgrad ring with an automatically sized persistent-buffer plan:
Symmetric reduce-scatter inputs are allocated from the registered memory pool for their exact GTP or expert-GTP process group. Dense and expert GTP therefore cannot alias storage registered for a different communicator, allowing NCCL one-shot RS to work with local CUDA graphs.
Persistent storage coverage
The plan now manages:
Ungraphed execution continues to use the existing eager buffer pools and cache paths.
The centralized discovery, allocation, and replay-fencing API can also support additional graph-owned GTP storage in the future. This PR does not add CUDA graph offloading support.
Contribution process
Pre-checks
Convergence
1/4 Nemotron-4 Proxy, 8 nodes, blue: eager, red: partialcg, no mtp.
