Repository navigation
Allow text-only batches in MIMO encoder prefetch - #6033
Closed
yashaswikarnati wants to merge 9 commits into
Closed
yashaswikarnati wants to merge 9 commits into
yashaswikarnati wants to merge 9 commits into
Conversation
Signed-off-by: ykarnati <ykarnati@nvidia.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
input_idsWhy
Real multimodal datasets can produce text-only microbatches. The encoder-prefetch loader currently rejects those batches before the MIMO model can use its existing empty-encoder-output path.
Validation
5587057: 5 nodes / 20 GPUs, encoder DP 4, LLM DP/EP 16, GBS 32, four dataloader workers, prefetch depth 4Dependency
This is a stacked draft on top of #5833 because encoder prefetch is not yet present on
main. After #5833 lands, this branch should be rebased ontomain, leaving the single fix commitc8cc9aabb5.