Skip to content

Avoid offsetting functional test master port - #4973

Merged
chtruong814 merged 1 commit into
NVIDIA:mainfrom
chtruong814:chtruong/fix-addr-use
May 25, 2026
Merged

Avoid offsetting functional test master port#4973
chtruong814 merged 1 commit into
NVIDIA:mainfrom
chtruong814:chtruong/fix-addr-use

Conversation

@chtruong814

@chtruong814 chtruong814 commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Remove the phase-based MASTER_PORT offset from functional test training launches.
  • Keep multi-node phase barriers and exit-code synchronization intact.
  • Avoid binding to unchecked derived ports that can already be in use.

Validation:

  • bash -n tests/functional_tests/shell_test_utils/_run_training.sh
  • bash -n tests/functional_tests/shell_test_utils/run_ci_test.sh
  • git diff --check

@chtruong814
Avoid offsetting functional test master port
82240da 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented May 25, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@chtruong814
chtruong814 marked this pull request as ready for review May 25, 2026 13:35
@chtruong814
chtruong814 requested a review from a team as a code owner May 25, 2026 13:35
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team May 25, 2026 13:35
@chtruong814

chtruong814 commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 82240da

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label May 25, 2026
@chtruong814
chtruong814 enabled auto-merge May 25, 2026 16:05
@chtruong814
chtruong814 added this pull request to the merge queue May 25, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented May 25, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/26409499782

Merged via the queue into NVIDIA:main with commit 2bd9fd5 May 25, 2026
369 of 374 checks passed
@chtruong814
chtruong814 deleted the chtruong/fix-addr-use branch May 25, 2026 16:46
santhnm2 pushed a commit to santhnm2/Megatron-LM that referenced this pull request May 26, 2026
@chtruong814 @santhnm2
Avoid offsetting functional test master port (NVIDIA#4973)
41a2af4 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Victarry pushed a commit to yanring/Megatron-LM that referenced this pull request May 27, 2026
Dennis Liu
Merge remote-tracking branch 'origin/main' into pr3431-conflict-fix
535f9d9 
* origin/main: (50 commits)
  Drain predecessor reduce-scatter at dispatch time (NVIDIA#4940)
  ci: Add allow_failure flag to gpt and moe recipes that are failing in nightlies (NVIDIA#4905)
  fix(tests): initialize num_microbatches calculator in vision cudagraph tests (NVIDIA#4986)
  test: re-enable test_pp2_create_cudagraphs_first_stage on TE 2.15+ (NVIDIA#4985)
  ci: Add support for MBridge job gating based on PR labels  (NVIDIA#4926)
  test(ci): re-enable 8experts2parallel_multi_dist_optimizer_instances_1node (NVIDIA#4984)
  test: re-enable paged stashing MoE tests (NVIDIA#4978)
  Fix elastification unwrap_model import (NVIDIA#4972)
  Avoid offsetting functional test master port (NVIDIA#4973)
  test: enable NVTE_CUTEDSL_FUSED_GROUPED_MLP via pytest fixture (NVIDIA#4931)
  chore(beep boop 🤖): Bump  (main) (2026-05-25)
  test(release): add release goldens for deepseekv3/nemotron3 and set tp2pp2 exit-interval (NVIDIA#4932)
  Fix `get_batch` return order to ignore BlendedDataset provenance fields (NVIDIA#4952)
  ci: restore perf test torchrun logs (NVIDIA#4951)
  Various training utils (NVIDIA#4872)
  ci: Update training script paths in BERT and T5 (NVIDIA#4939)
  [MXFP8/FP4-param-gather] Post processing after forced param AG in eval (NVIDIA#4562)
  Fix mxfp8 param gather numerical issue when DP overlap is off (NVIDIA#4800)
  Add TEFusedDenseMLP for Dense+Grouped GEMM fusion on SM100+ (NVIDIA#4318) (NVIDIA#4786)
  Fix paged stashing test submodules lookup (NVIDIA#4925)
  ...

# Conflicts:
#	megatron/training/training.py
janEbert pushed a commit to janEbert/Megatron-LM that referenced this pull request Jun 2, 2026
@chtruong814 @janEbert
Avoid offsetting functional test master port (NVIDIA#4973)
f9c1998 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
mathemakitten pushed a commit to mathemakitten/Megatron-LM that referenced this pull request Jun 12, 2026
@chtruong814 @mathemakitten
Avoid offsetting functional test master port (NVIDIA#4973)
aa8ecdd 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
@chtruong814 @yhgalaxy
Avoid offsetting functional test master port (NVIDIA#4973)
8dc12c3 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
@chtruong814 Jon Barker
Avoid offsetting functional test master port (NVIDIA#4973)
5f66c90 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
@chtruong814 @terminator123
Avoid offsetting functional test master port (NVIDIA#4973)
98d49d1 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
@chtruong814 @dimapihtar
Avoid offsetting functional test master port (NVIDIA#4973)
44a45f5 
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>

This branch was previously deployed

2 inactive deployments
public — 82240dab Deployed May 25, 2026 by copy-pr-bot[bot] via finalize / publish-docs #964
test — 82240dab Deployed May 25, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #14142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ko3n1g ko3n1g ko3n1g approved these changes

Assignees

No one assigned

Labels

Approved All necessary approvals have been made complexity: low Run tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chtruong814 @svcnvidia-nemo-ci @ko3n1g