Skip to content

ci: enable ft_launcher for 6 resume-from-checkpoint test cases - #4304

Closed
ko3n1g wants to merge 2 commits into
NVIDIA:mainfrom
ko3n1g:ko3n1g/ci/ft-launcher-resume-tests
Closed

ko3n1g wants to merge 2 commits into
NVIDIA:mainfrom
ko3n1g:ko3n1g/ci/ft-launcher-resume-tests

Conversation

@ko3n1g

@ko3n1g ko3n1g commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Depends on #4298 (branched from ko3n1g/feat/ft-launcher-ci)

Enable ft_launcher (nvidia-resiliency-ext fault-tolerance launcher) for 6 distributed optimizer / checkpoint-resume test cases.

GPT:

  • gpt3_mcore_te_tp1_pp4_vp1_resume_torch_dist_dist_optimizer_overlap_grad_reduce_param_gather
  • gpt3_mcore_te_tp2_pp1_resume_torch_dist_multi_dist_optimizer_instances
  • gpt3_mcore_te_tp4_pp1_resume_torch_dist_dist_optimizer_overlap_grad_reduce_param_gather

MoE:

  • gpt3_mcore_te_tp1_pp2_resume_torch_dist_reshard_2x1x4_te_8experts2parallel_dist_optimizer
  • gpt3_mcore_te_tp2_pp1_resume_torch_dist_te_8experts2parallel_multi_dist_optimizer_instances
  • gpt3_moe_mcore_te_tp4_ep2_etp2_pp2_resume_torch_dist_dist_optimizer

Each test gets LAUNCHER: ft_launcher added to its model_config.yaml, which opts it in to the fault-tolerance launcher introduced in #4298.

Example change

TEST_TYPE: ckpt-resume
LAUNCHER: ft_launcher

Test plan

  • CI passes on all 6 enabled test cases using ft_launcher
  • Remaining test cases unaffected (default torchrun behaviour)

🤖 Generated with Claude Code

ko3n1g and others added 2 commits April 14, 2026 14:13
Introduce a top-level `LAUNCHER` key in `model_config.yaml` (default:
`torchrun`) that allows individual test cases to opt into `ft_launcher`
(nvidia-resiliency-ext fault-tolerance launcher) as a drop-in torchrun
replacement.  All distributed arguments are forwarded unchanged; only the
launcher binary is switched.

Resolves AUT-360

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Enable ft_launcher (nvidia-resiliency-ext fault-tolerance launcher) for
the following distributed optimizer / checkpoint-resume test cases:

GPT:
- gpt3_mcore_te_tp1_pp4_vp1_resume_torch_dist_dist_optimizer_overlap_grad_reduce_param_gather
- gpt3_mcore_te_tp2_pp1_resume_torch_dist_multi_dist_optimizer_instances
- gpt3_mcore_te_tp4_pp1_resume_torch_dist_dist_optimizer_overlap_grad_reduce_param_gather

MoE:
- gpt3_mcore_te_tp1_pp2_resume_torch_dist_reshard_2x1x4_te_8experts2parallel_dist_optimizer
- gpt3_mcore_te_tp2_pp1_resume_torch_dist_te_8experts2parallel_multi_dist_optimizer_instances
- gpt3_moe_mcore_te_tp4_ep2_etp2_pp2_resume_torch_dist_dist_optimizer

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
ko3n1g requested a review from a team as a code owner April 14, 2026 17:55
@ko3n1g

ko3n1g commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft April 14, 2026 17:55
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Apr 14, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 14, 2026
@ko3n1g

ko3n1g commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favour of merging directly into #4298.

This branch was previously deployed

1 inactive deployment
test — 01c00769 Deployed Apr 14, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #11483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants