Repository navigation
cp: NVFP4 native weights for DDP (4005) into core_r0.17.0 - #4290
Merged
Merged
Conversation
Signed-off-by: qiyuw <qiyuw@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Contributor
Author
|
/ok to test 66c8892 |
ko3n1g
marked this pull request as draft
April 16, 2026 14:29
ko3n1g
marked this pull request as ready for review
April 16, 2026 23:15
lxd-cumt
added a commit
to lxd-cumt/Megatron-LM-FL
that referenced
this pull request
Apr 22, 2026
Upstream changes (10 commits since d1c2e49): - Bump mfsdp to 0.4.0 - Add NVFP4 native weights support for DDP (NVIDIA#4290) - Documentation updates (version picker, project.json) - Various bug fixes and improvements Key changes merged: - megatron/core/distributed/param_and_grad_buffer.py: NVFP4 dual-buffer support - megatron/core/optimizer/distrib_optimizer.py: FP4 param handling - megatron/core/fp4_utils.py: New FP4 utilities - megatron/core/distributed/fsdp/: Version bump to 0.4.0 - tests/unit_tests/test_fp4_param.py: New FP4 unit tests FlagScale-specific handling: - Preserved all cur_platform patches (torch.cuda → cur_platform) - Kept full kitchen.py implementation (upstream stubbed it out) - Excluded megatron/training/arguments.py (managed by FlagScale) - All megatron/plugin/ files remain intact (FlagScale-specific) Conflicts resolved: - megatron/core/distributed/fsdp/src/megatron_fsdp/package_info.py: version 0.4.0 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
lxd-cumt
added a commit
to lxd-cumt/Megatron-LM-FL
that referenced
this pull request
Apr 22, 2026
Upstream changes (10 commits since 9539a12): - NVFP4 native weights support for DDP (NVIDIA#4290) - Bump mfsdp to 0.4.0 - Documentation and version updates Overlapping files (upstream + cur_platform patches preserved): - distributed_data_parallel.py: added NVFP4 support - param_and_grad_buffer.py: NVFP4 dual-buffer layout - distrib_optimizer.py: FP4 param handling New upstream files taken as-is: - fp4_utils.py, test_fp4_param.py, distributed_data_parallel_config.py Excluded: megatron/training/arguments.py (managed by FlagScale)
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beep boop [🤖]: Hi @WanZzzzzz 👋,