Skip to content

feat(ci): add strict review mode to Claude review workflow - #4197

Merged
Victarry merged 1 commit into
NVIDIA:mainfrom
Victarry:denliu/claude-review-strict-mode-main
Apr 14, 2026
Merged

feat(ci): add strict review mode to Claude review workflow#4197
Victarry merged 1 commit into
NVIDIA:mainfrom
Victarry:denliu/claude-review-strict-mode-main

Conversation

@Victarry

@Victarry Victarry commented Apr 8, 2026

Copy link
Copy Markdown

Summary

  • Add /claude strict-review trigger for comprehensive Megatron-LM focused code review
  • Covers implementation correctness, parallelism, training performance, backward compatibility, and unused variable checks
  • Existing /claude review trigger preserved as light review mode

Test plan

  • Comment /claude review on a PR → light review triggers
  • Comment /claude strict-review on a PR → strict review triggers with full Megatron-LM criteria

🤖 Generated with Claude Code

@Victarry
Victarry requested a review from a team as a code owner April 8, 2026 08:56
@copy-pr-bot

copy-pr-bot Bot commented Apr 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft April 8, 2026 08:56
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@Victarry
Victarry marked this pull request as ready for review April 8, 2026 09:04
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team April 8, 2026 09:04
@yaox12
yaox12 requested a review from Phlip79 April 8, 2026 09:07
@Victarry

Victarry commented Apr 8, 2026

Copy link
Copy Markdown
Author

Hi @Phlip79 , do you know how to run the newly added claude review before it get merged?

@Victarry

Victarry commented Apr 9, 2026

Copy link
Copy Markdown
Author

/ok to test c71c12a

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 9, 2026
@Phlip79

Phlip79 commented Apr 9, 2026

Copy link
Copy Markdown
Member

/claude strict-review

@Phlip79

Phlip79 commented Apr 9, 2026

Copy link
Copy Markdown
Member

Hi @Phlip79 , do you know how to run the newly added claude review before it get merged?

I don't think so. You can always ask Claude to help you create a fake test.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Apr 13, 2026
@Victarry
Victarry enabled auto-merge April 13, 2026 16:06
@Victarry
Victarry added this pull request to the merge queue Apr 13, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24353629235

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24357632333

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 13, 2026
@Phlip79

Phlip79 commented Apr 13, 2026

Copy link
Copy Markdown
Member

@Victarry can you please sync from main, there's a bugfix (#4259) that will resolve the merge.

Dennis Liu @claude
feat(ci): add strict review mode to Claude review workflow
eaffe85 
Add a `/claude strict-review` trigger for comprehensive Megatron-LM
focused code review covering implementation correctness, parallelism,
training performance, backward compatibility, and unused variable checks.
The existing `/claude review` trigger is preserved as a light review mode.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Victarry
Victarry force-pushed the denliu/claude-review-strict-mode-main branch from c71c12a to eaffe85 Compare April 14, 2026 01:02
@Victarry

Victarry commented Apr 14, 2026

Copy link
Copy Markdown
Author

/ok to test eaffe85

@Victarry
Victarry added this pull request to the merge queue Apr 14, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24383282551

Merged via the queue into NVIDIA:main with commit e9e513a Apr 14, 2026
63 checks passed
@Victarry
Victarry deleted the denliu/claude-review-strict-mode-main branch April 14, 2026 06:29
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Dennis(Zhenhuan) Liu @claude
feat(ci): add strict review mode to Claude review workflow (NVIDIA#4197)
cbc1ee3 
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
Dennis(Zhenhuan) Liu @claude @yhgalaxy
feat(ci): add strict review mode to Claude review workflow (NVIDIA#4197)
74471ab 
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
Dennis(Zhenhuan) Liu @claude Jon Barker
feat(ci): add strict review mode to Claude review workflow (NVIDIA#4197)
74b798a 
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Dennis(Zhenhuan) Liu @claude @terminator123
feat(ci): add strict review mode to Claude review workflow (NVIDIA#4197)
a0ee8fc 
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
test — eaffe855 Deployed Apr 14, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #11411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Phlip79 Phlip79 Phlip79 approved these changes
@chtruong814 chtruong814 chtruong814 approved these changes

Assignees

No one assigned

Labels

Approved All necessary approvals have been made complexity: medium

Projects

None yet

Milestone

Core 0.16

Development

Successfully merging this pull request may close these issues.

4 participants

@Victarry @Phlip79 @svcnvidia-nemo-ci @chtruong814