Skip to content

Add more emerging optimizers (#3907) - #4119

Merged
skyw merged 4 commits into
NVIDIA:mainfrom
skyw:add-more-emerging-optimizers
Apr 3, 2026
Merged

Add more emerging optimizers (#3907)#4119
skyw merged 4 commits into
NVIDIA:mainfrom
skyw:add-more-emerging-optimizers

Conversation

@skyw

@skyw skyw commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Add #3907 to main.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@skyw
skyw requested review from a team as code owners April 3, 2026 02:35
@copy-pr-bot

copy-pr-bot Bot commented Apr 3, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft April 3, 2026 02:35
@skyw
skyw marked this pull request as ready for review April 3, 2026 02:35
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team April 3, 2026 02:35
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Apr 3, 2026
@skyw

skyw commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 0cfe331

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 3, 2026
@skyw
style improvement
fd91d52 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw

skyw commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test fd91d52

deepakn94
deepakn94 reviewed Apr 3, 2026
View reviewed changes
Comment thread megatron/core/optimizer/emerging_optimizers.py Outdated
# Checkpoint init needs state for all parameters, including those without grads yet.
opt._init_group(group, skip_non_grad_params=False)
class TensorParallelAdaptiveMuon(TensorParallelMuon, AdaptiveMuon):
"""Tensor Parallel Adaptive Muon optimizer."""

@deepakn94 deepakn94 Apr 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend docstring to describe briefly what Adaptive Muon is and differences compared to Muon?

deepakn94
deepakn94 approved these changes Apr 3, 2026
View reviewed changes

@deepakn94 deepakn94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request for additional docstring, but approving.

@skyw

skyw commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 3ad3670

@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Apr 3, 2026
@skyw
skyw enabled auto-merge April 3, 2026 16:45
@skyw
skyw added this pull request to the merge queue Apr 3, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23954415758

Merged via the queue into NVIDIA:main with commit c9797ad Apr 3, 2026
65 of 67 checks passed
@skyw
skyw deleted the add-more-emerging-optimizers branch April 3, 2026 17:37
@ko3n1g ko3n1g mentioned this pull request Apr 6, 2026
Closed
3 tasks
ko3n1g added a commit to ko3n1g/Megatron-LM that referenced this pull request Apr 6, 2026
@ko3n1g
Revert "Add more emerging optimizers (NVIDIA#3907) (NVIDIA#4119)"
ba6f008 
This reverts commit c9797ad.

Signed-off-by: oliver könig <okoenig@nvidia.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
@skyw
Add more emerging optimizers (NVIDIA#3907) (NVIDIA#4119)
79055d1 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@ko3n1g ko3n1g mentioned this pull request May 26, 2026
Closed
@sbhavani sbhavani mentioned this pull request May 26, 2026
Closed
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
@skyw @yhgalaxy
Add more emerging optimizers (NVIDIA#3907) (NVIDIA#4119)
344b21e 
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
@skyw Jon Barker
Add more emerging optimizers (NVIDIA#3907) (NVIDIA#4119)
2a21704 
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
@skyw @terminator123
Add more emerging optimizers (NVIDIA#3907) (NVIDIA#4119)
c2bb53b 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@sudhu2k sudhu2k mentioned this pull request Aug 28, 2026
Merged

This branch was previously deployed

1 inactive deployment
test — 3ad3670b Deployed Apr 3, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #10842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepakn94 deepakn94 deepakn94 approved these changes
@yaoyu-33 yaoyu-33 yaoyu-33 approved these changes

Assignees

No one assigned

Labels

Approved All necessary approvals have been made complexity: medium

Projects

None yet

Milestone

Core 0.16

Development

Successfully merging this pull request may close these issues.

4 participants

@skyw @svcnvidia-nemo-ci @deepakn94 @yaoyu-33