Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Dataset visualization - #331

Merged
lukeyeager merged 1 commit into
NVIDIA:masterfrom
Deepomatic:datasetviz
Oct 6, 2015
Merged

Dataset visualization#331
lukeyeager merged 1 commit into
NVIDIA:masterfrom
Deepomatic:datasetviz

Conversation

@groar

@groar groar commented Sep 28, 2015

Copy link
Copy Markdown

Closes #21

Implemented some way to visualize a dataset db as a gallery, solving #21. I did that to debug #330, as some transformations were not doing what I expected.

You can browse a dataset page by page, reading directly from the db. For now it's only working with lmdb . You can filter by one of the labels from the classification task, as well as change the number of images displayed.

Screenshot 1

The explorer is accessible from a button in the dataset show view, once a task is done.
Screenshot 2

The UI is a bit rough and can probably be improved but at least it's functional.

I'll write some tests when I have enough time.

@lukeyeager

Copy link
Copy Markdown
Member

Great stuff, thanks @groar!

I'm trying to test it out, but I keep getting this error:

datasetviz-error

I tried it with PNG, JPEG and raw data in LMDBs - always got the same error.

@groar

groar commented Sep 28, 2015

Copy link
Copy Markdown
Author

That's super weird @lukeyeager. I can't understand why you get those kinds of errors (it's the same problem for #137) while I don't. It works for PNG, JPEG, grayscale or color, or any other settings for me. I'm going to investigate the problem, but I can't manage to reproduce it.

@lukeyeager

Copy link
Copy Markdown
Member

Can anyone else test this? Is it working on Travis? The latest build timed out, I restarted it ...

@groar

groar commented Sep 28, 2015

Copy link
Copy Markdown
Author

I didn't write any test that uses it. Will do that !

@groar

groar commented Sep 28, 2015

Copy link
Copy Markdown
Author

Ok I pushed a test for the view, so we'll see.

@lukeyeager

Copy link
Copy Markdown
Member

That did it for me. Maybe it was just the little s.seek(0) command that I needed?

datasetvis-working

UI suggestions:

  • If all images fit on the page, don't enable the button that moves to the next page.
  • Can we list the classes horizontally instead of vertically? That's going to look ridiculous with 1000 classes. Maybe this?

Otherwise this looks pretty awesome! I'd like to get @jmancewicz to sign off on this before merging.

@groar

groar commented Sep 28, 2015

Copy link
Copy Markdown
Author

yeah I tried the s.seek(0) even though it doesn't change anything on my side. Great if that's work. Yeah, I'm going to change the UI !

@gheinrich

Copy link
Copy Markdown
Contributor

Thanks @groar, this is very useful!

On my CIFAR10 dataset I have 37500 training examples. If I select 10 items per page the list of pages goes from 0 to 3750 (instead of 0--3749 or 1--3750) and on page #3750 there are no images to display.

Also, when I am trying to explore my validation DB, if I click on any link of the exploration page I seem to be redirected to the train DB.

@groar

groar commented Sep 29, 2015

Copy link
Copy Markdown
Author

Thanks for the feedback @gheinrich and @lukeyeager ! I handled all the UI bugs and improvements you mentioned and squashed the commits.

@groar
groar force-pushed the datasetviz branch 2 times, most recently from 13d1d1c to 61a256d Compare September 29, 2015 16:09
@lukeyeager

Copy link
Copy Markdown
Member

Looks good to me! Squash this into one commit on top of the master branch with a reasonable commit message and I'll merge it.

git remote update
git rebase -i origin/master

@gheinrich

Copy link
Copy Markdown
Contributor

Looks good to me too, thanks!

@jmancewicz

Copy link
Copy Markdown
Contributor

This is very nice. Thanks. Everything looks good.

@groar
groar force-pushed the datasetviz branch 5 times, most recently from 20d0ea1 to a347dee Compare October 4, 2015 19:50
@gheinrich

Copy link
Copy Markdown
Contributor

@groar would you like to rebase on the tip of the master branch?

regenerated doc
@groar

groar commented Oct 5, 2015

Copy link
Copy Markdown
Author

Done that !

lukeyeager added a commit that referenced this pull request Oct 6, 2015
@lukeyeager
lukeyeager merged commit 435b462 into NVIDIA:master Oct 6, 2015
@lukeyeager

Copy link
Copy Markdown
Member

Thanks @groar!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants