Show Create DB log in dataset view

[gheinrich]

No description provided.

[lukeyeager]

That's a little wordy. Would create_%s.log be too short?

[lukeyeager]

Great PR! This should definitely help with some of the confusion about DIGITS silently ignoring errors when creating datasets.

[lukeyeager]

No need to explicitly delete the dataset. It will be deleted in tearDownClass():

DIGITS/digits/dataset/images/classification/test_views.py

Lines 82 to 84 in f3c4078

	# delete any created datasets
	for job_id in cls.created_datasets:
	cls.delete_dataset(job_id)

[gheinrich]

Thanks for the feedback Luke! I have made the changes you suggested. I am not sure why code coverage went down. The tool reports a miss on lines https://github.com/gheinrich/DIGITS/blob/dev/createDbLog/digits/dataset/images/classification/test_views.py#L267-L274 even though they are part of a test that passed.

This opens an interesting can of worms. Do you envision exposing all available files via the REST API eventually?

I leave this decision to you :-)

[lukeyeager]

I am not sure why code coverage went down

I've noticed that there are some lines in the scheduler which run sometimes and not others. It's not really a problem, but it makes our test coverage vary somewhat from run to run.

The tool reports a miss on lines ... even though they are part of a test that passed

Yeah that's weird.

[lukeyeager]

Can we use .log instead of .txt? That's what we have for the Caffe output.

[gheinrich]

Yes, sorry I read the first comment too quickly. I used the .txt extension because in Firefox it shows the file automatically without asking the user to download/choose an external tool to open it. But you're right, it's better to keep consistency in the project.