feat: Update sft config to use single GPU#90
Merged
Conversation
Signed-off-by: ashors1 <ashors@nvidia.com>
ashors1
changed the title
Contributor
|
Can you verify that the loss is at least somewhat going down with the new default before we merge? Otherwise, lgtm. |
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Contributor
|
@SahilJain314 @ashors1 I've added slightly different defaults for 1 GPU job. Both train and val curves go down enough. |
Contributor
Author
|
LGTM @okuchaiev. Out of curiosity, is there a reason you decreased the sequence length to 1k? Were you running into OOM with 2k? |
Contributor
|
No, I wasn't running OOM with 2K. But for SQUAD, I think, even 1K could be an overkill. |
terrykong
approved these changes
Mar 31, 2025
yfw
pushed a commit
that referenced
this pull request
Apr 2, 2025
Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
KiddoZhu
pushed a commit
that referenced
this pull request
May 6, 2025
Signed-off-by: ashors1 <ashors@nvidia.com> Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information