fix: change format messages to out of place#77
Merged
parthchadha merged 4 commits intomainfrom Mar 31, 2025
Merged
Conversation
Signed-off-by: KiddoZhu <zhaochengz@nvidia.com>
KiddoZhu
force-pushed
the
format-messages-out-of-place
branch
from
84b03fd to
970dd10
Compare
Contributor
|
i definitely stand behind making things more functionally pure! We're trying to push v0.1.1, but i triggered the CI to prefetch |
terrykong
previously approved these changes
Mar 25, 2025
parthchadha
previously approved these changes
Mar 25, 2025
KiddoZhu
dismissed stale reviews from SahilJain314, terrykong, and parthchadha
via
89522d0
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
SahilJain314
force-pushed
the
format-messages-out-of-place
branch
from
4c86158 to
8f4667a
Compare
parthchadha
approved these changes
Mar 31, 2025
yfw
pushed a commit
that referenced
this pull request
Apr 2, 2025
Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <sahilj@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
KiddoZhu
added a commit
that referenced
this pull request
May 6, 2025
Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Sahil Jain <sahilj@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Existing implementation of
get_formatted_message_log()modifiesmessage_login-place and is not reentrant. This PR fixes it.Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information