Repository navigation
perf(checkpoint): batch generation-prefix TQ writes - #4389
Closed
macandro96 wants to merge 2 commits into
Closed
macandro96 wants to merge 2 commits into
macandro96 wants to merge 2 commits into
Conversation
Signed-off-by: Anish Mahishi <amahishi@aws-cmh-slurm-1-vscode-01.cm.cluster>
Contributor
Author
|
/ok to test 2c646aa |
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
Contributor
Author
|
/ok to test 9812a07 |
Contributor
Author
|
Superseded by #4508, which carries the batched generation-prefix writes (plus coalesced restore reads) on the current prefix-recovery stack. Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Batch generation-prefix writes to TransferQueue during prefix-level rollout checkpoint cuts.
This is a stacked PR based on
amahishi/prefix-recovery-core. It:TQTokenSinkAPI that preserves jagged token fields and separates incompatible optional schemas;1;Issues
This is part of the prefix-level rollout checkpointing stack.
Usage
Configure the checkpoint batching limits under
rollout_checkpointing:The generation owner gathers active prefixes until either limit is reached, then performs one TQ
put_samplesoperation for each compatible schema group.Before your PR is "Ready for review"
Pre checks:
Additional Information
Local validation completed:
git diff --checkThe focused pytest suite was not run locally because the repository's locked runtime supports Linux while the available development host is macOS ARM. The tests should be run in Linux CI or on the cluster.
Base branch dependency:
amahishi/prefix-recovery-core.