Conversation
ZhiyuLi-Nvidia
force-pushed
the
zhiyul/duel_clip
branch
from
460cd89 to
76d101b
Compare
SahilJain314
suggested changes
May 3, 2025
Contributor
SahilJain314
left a comment
SahilJain314
left a comment
There was a problem hiding this comment.
small description correctness and grammar changes
SahilJain314
previously approved these changes
May 5, 2025
parthchadha
reviewed
May 5, 2025
SahilJain314
reviewed
May 5, 2025
github-actions
bot
added
the
documentation
ZhiyuLi-Nvidia
force-pushed
the
zhiyul/duel_clip
branch
2 times, most recently
from
d362eb1 to
e2a1448
Compare
SahilJain314
previously approved these changes
May 5, 2025
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
Co-authored-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: ZhiyuLi-Nvidia <zhiyul@NVIDIA.com>
Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
ZhiyuLi-Nvidia
force-pushed
the
zhiyul/duel_clip
branch
from
e2a1448 to
482d058
Compare
Contributor
Author
|
@parthchadha @terrykong do you have any other comments? |
terrykong
reviewed
May 7, 2025
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
SahilJain314
reviewed
May 7, 2025
Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
parthchadha
previously approved these changes
May 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong
previously approved these changes
May 9, 2025
terrykong
approved these changes
May 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jun 10, 2025
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Signed-off-by: ZhiyuLi-Nvidia <zhiyul@NVIDIA.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: Terry Kong <terryk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add dual-clip support in grpo loss
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information