perf: update sft and dpo recipes to use bf16#302
Merged
Conversation
Signed-off-by: ashors1 <ashors@nvidia.com>
yfw
previously approved these changes
May 1, 2025
Contributor
|
@ashors1 could you share the convergence curves just for posterity |
Contributor
Author
Updated the PR description |
Contributor
|
@ashors1 there was a test failure https://github.com/NVIDIA/NeMo-RL/actions/runs/14841614037/job/41665718613 the functional sft test fails b/c the numerics have changed |
Contributor
Author
Yep, looking into it now |
Signed-off-by: ashors1 <ashors@nvidia.com>
Contributor
Author
|
@terrykong updated the test and manually verified that the increased loss is not a concern, as over time the curves are comparable |
terrykong
approved these changes
May 5, 2025
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jun 10, 2025
Signed-off-by: ashors1 <ashors@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
SFT FP32 vs BF16:

DPO FP32 vs BF16:

Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information