Skip to content

chore: bump mbridge and MLM - #2354

Closed
ashors1 wants to merge 17 commits into
mainfrom
ashors/bump-mbridge-mlm
Closed

chore: bump mbridge and MLM#2354
ashors1 wants to merge 17 commits into
mainfrom
ashors/bump-mbridge-mlm

Conversation

@ashors1

@ashors1 ashors1 commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@ashors1
Bump mbridge and MLM
9d923c3 
Signed-off-by: ashors1 <ashors@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Apr 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ashors1
fix dependency mismatch
c4e187e 
Signed-off-by: Anna Shors <ashors@nvidia.com>
@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: c4e187e (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)
Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: ba19dfb (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)
Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 9e8469e (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)
Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 1e4f42a (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)
Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@ashors1
fix MLM setup.py
0f3a50f 
Signed-off-by: ashors1 <ashors@nvidia.com>
@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 0f3a50f (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)
Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@ashors1
update uv.lock
f0535cc 
Signed-off-by: ashors1 <ashors@nvidia.com>
@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: f0535cc (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)
Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@ashors1
fix mbridge sestup.py
3061928 
Signed-off-by: ashors1 <ashors@nvidia.com>
@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 3061928 (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)
Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@yuekaizhang

yuekaizhang commented May 19, 2026

Copy link
Copy Markdown
Contributor

@ashors1 Thanks for the great work! Just wondering — do you have a rough idea of when the PR might be merged?

@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 6177a77 (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@ashors1
bump mbridge
bde9211 
Signed-off-by: ashors1 <ashors@nvidia.com>
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: bde9211 (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: c2e6782 (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@ashors1
update mbridge
598883b 
Signed-off-by: ashors1 <ashors@nvidia.com>
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 598883b (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@ashors1

ashors1 commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

@ashors1 Thanks for the great work! Just wondering — do you have a rough idea of when the PR might be merged?

@yuekaizhang Sorry for the late reply. I am currently running tests to make sure the bump doesn't introduce any regressions. If the tests pass, hopefully we can get the PR in very soon. But if the tests fail, I might need to spend a few days debugging. We have many PRs we are trying to get in a the moment and this one is not the highest priority unfortunately.

ashors1 added 2 commits May 26, 2026 10:41
@ashors1
fixes
1756798 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
Merge branch 'main' of github.com:NVIDIA-NeMo/RL into ashors/bump-mbr…
c25d18b 
…idge-mlm
@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: c25d18b (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@ashors1
fix dependency issue
b29edc7 
Signed-off-by: Anna Shors <ashors@nvidia.com>
@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: b29edc7 (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 4e76cec (PR #2354 from ashors/bump-mbridge-mlm)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@ashors1
make z3 directory findable
3f6a5e4 
Signed-off-by: Anna Shors <ashors@nvidia.com>
zpqiu added a commit to zpqiu/RL that referenced this pull request Jun 3, 2026
@zpqiu @claude
chore: bump Megatron-Bridge to 7918b0f (+ MLM) and sync deps
4ab56ac 
Bump the Megatron-Bridge submodule to 7918b0f2 (nested Megatron-LM to
38986a98), mirroring the dependency changes from PR NVIDIA-NeMo#2354
(ashors/bump-mbridge-mlm):

- transformers 5.3 -> 5.8.1,<5.9.0 in the megatron-bridge proxy
  CACHED_DEPENDENCIES and root static dependency-metadata
- drop transformer-engine / mamba-ssm / causal-conv1d from the
  megatron-bridge dep set (now extras upstream); move mamba-ssm +
  causal-conv1d to the mcore extra
- add mistral-common, flashinfer-python, flashinfer-cubin
- bump nvidia-resiliency-ext rev and logsage metadata to 0.1.7
- regenerate uv.lock (PR lock minus pytest-shard, which our main drops)
- Dockerfile: make z3-solver libz3 discoverable for fla/tilelang
- modelopt worker: register "nemo_rl." as an mbridge allowed target
  prefix (new API in this Megatron-Bridge)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
zpqiu added a commit to zpqiu/RL that referenced this pull request Jun 3, 2026
@zpqiu @claude
chore: bump Megatron-Bridge to 7918b0f (+ MLM) and sync deps
8da9cb2 
Bump the Megatron-Bridge submodule to 7918b0f2 (nested Megatron-LM to
38986a98), mirroring the dependency changes from PR NVIDIA-NeMo#2354
(ashors/bump-mbridge-mlm):

- transformers 5.3 -> 5.8.1,<5.9.0 in the megatron-bridge proxy
  CACHED_DEPENDENCIES and root static dependency-metadata
- drop transformer-engine / mamba-ssm / causal-conv1d from the
  megatron-bridge dep set (now extras upstream); move mamba-ssm +
  causal-conv1d to the mcore extra
- add mistral-common, flashinfer-python, flashinfer-cubin
- bump nvidia-resiliency-ext rev and logsage metadata to 0.1.7
- regenerate uv.lock (PR lock minus pytest-shard, which our main drops)
- Dockerfile: make z3-solver libz3 discoverable for fla/tilelang
- modelopt worker: register "nemo_rl." as an mbridge allowed target
  prefix (new API in this Megatron-Bridge)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
@terrykong terrykong closed this Jun 25, 2026
jQizhang added a commit that referenced this pull request Jul 6, 2026
@jQizhang
chore(automodel): bump submodule to 9c232dc7d
1ba6b84 
Advance 3rdparty/Automodel-workspace/Automodel from fa0f60144 to
9c232dc7d (90 upstream commits), including CP support for MiniMax M3
(#2551), vision biencoder finetuning + Nemotron VL 1B support (#2354),
and DDP selective checkpointing (#2786).

Signed-off-by: larkzhang-nv <larkz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashors1 @yuekaizhang @terrykong