Skip to content

ci: Add initial GHA#1

Merged
chtruong814 merged 18 commits intomainfrom
initial-gha
Mar 19, 2025
Merged

ci: Add initial GHA#1
chtruong814 merged 18 commits intomainfrom
initial-gha

Conversation

@chtruong814
Copy link
Contributor

@chtruong814 chtruong814 commented Mar 18, 2025

  • Add initial GHA to lint and run unit tests as well as release steps, copying over similar steps from other repos.
  • "Unit tests" only run on Github runner for now. We can replace with GPU runners when we are running real tests.
  • We will want to replace _placeholder throughout these files when we formally update the name
  • Commenting out the build test publish step for now since likely requires some setup on test pypi first

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 changed the title Add initial GHA ci: Add initial GHA Mar 18, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Copy link
Contributor

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this initial setup, it looks great! I left some suggestions and questions.


Please list *minimal* steps or code snippet for us to be able to reproduce the bug.

A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports.
A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports.

# branches:
# - main
# - 'r**'
# pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this would be great in theory, it would require a necessary change of our build-test-publish-wheel workflow: This pushes to (test-) pypi with each call. This easily fills up the pypi repository and at some point pypi will reject wheels. It is unclear so far, how to clean up old wheels.

For this reason, this workflow commonly runs only on push to main.

- 'main'

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}-${{ github.event.label.name || 'main' }}

A small quality of life hack: This will prevent the unintuitive behavior where attaching any label kills the ongoing workflow.

chtruong814 and others added 4 commits March 19, 2025 17:02
Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Copy link
Contributor Author

@ko3n1g thanks for the review. I updated based on the feedback. Please take another look when you have time.

@chtruong814 chtruong814 merged commit 4ec03c2 into main Mar 19, 2025
3 checks passed
@chtruong814 chtruong814 deleted the initial-gha branch March 19, 2025 22:55
KiddoZhu pushed a commit that referenced this pull request May 6, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
terrykong pushed a commit that referenced this pull request Jul 20, 2025
update uv.lock to account for the new dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants