Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
ko3n1g
left a comment
There was a problem hiding this comment.
Thank you for this initial setup, it looks great! I left some suggestions and questions.
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
|
|
||
| Please list *minimal* steps or code snippet for us to be able to reproduce the bug. | ||
|
|
||
| A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports. |
There was a problem hiding this comment.
| A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports. | |
| A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports. |
| # branches: | ||
| # - main | ||
| # - 'r**' | ||
| # pull_request: |
There was a problem hiding this comment.
While this would be great in theory, it would require a necessary change of our build-test-publish-wheel workflow: This pushes to (test-) pypi with each call. This easily fills up the pypi repository and at some point pypi will reject wheels. It is unclear so far, how to clean up old wheels.
For this reason, this workflow commonly runs only on push to main.
.github/workflows/cicd-main.yml
Outdated
| - 'main' | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} |
There was a problem hiding this comment.
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | |
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}-${{ github.event.label.name || 'main' }} |
A small quality of life hack: This will prevent the unintuitive behavior where attaching any label kills the ongoing workflow.
Co-authored-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
0d6a1cc to
dfb18e0
Compare
|
@ko3n1g thanks for the review. I updated based on the feedback. Please take another look when you have time. |
Signed-off-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
update uv.lock to account for the new dependency
_placeholderthroughout these files when we formally update the name