Repository navigation
fix(training): correct diagnostic rank selection and repeated logs - #6211
Merged
Merged
Conversation
Signed-off-by: Chen Cui <chcui@nvidia.com>
Contributor
|
Light review — looks solid overall. The rank-selection fixes and the empty profile_ranks semantics are internally consistent (the memory-snapshot guards now match should_profile_rank in profiling.py, which already treats an empty list as all-ranks), and the new tests cover both branches well. One documentation inaccuracy to flag:
Minor observations (no action needed):
Suggested test cases:
No perf/recipe configs are touched — No perf tests impacted. |
Signed-off-by: Chen Cui <chcui@nvidia.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty
profile_rankslist currently disables allocator history and snapshots, and non-colocated MIMO can omit language-model setup diagnostics. This corrects logging rank selection and repeated external messages:Syncs NVIDIA/Megatron-LM#6354, NVIDIA/Megatron-LM#7360, NVIDIA/Megatron-LM#5590, and NVIDIA/Megatron-LM#7414. Performance changes are outside this PR.
Validation: 246 focused logging, training utility, initialization, and MIMO provider tests passed in the NeMo 26.08.rc9 container against the pinned MCore. All-file pre-commit, Ruff checks, and format checks passed. Strict mypy remains blocked by missing optional dependency stubs and existing errors in these modules in the host tooling environment.