Repository navigation
Fix MLM!4103 - #3931
Closed
asolergi-nv wants to merge 2 commits into
Closed
Fix MLM!4103#3931asolergi-nv wants to merge 2 commits into
asolergi-nv wants to merge 2 commits into
Conversation
Contributor
Light Code ReviewMissing mock updates (potential test breakage) This PR updates all source call sites and some test mocks for the new is_hybrid_cp parameter on get_batch_on_this_cp_rank, but misses updating 5 test mocks that use lambda x: x - these will raise TypeError if actually invoked with the new keyword argument:
These should be updated to lambda x, **kwargs: x to match the fix applied in test_dgpt_step.py:473. PR hygiene The PR title and description are not filled in - consider adding a one-line summary of the upstream MCore change being adapted to (MLM!4103) and listing the affected call sites. Suggested test cases No perf tests impacted. Unit tests that should be verified:
|
ko3n1g
previously approved these changes
May 22, 2026
yaoyu-33
approved these changes
May 22, 2026
Contributor
Author
|
Fixed in #3944 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
NVIDIA/Megatron-LM#4103 Introduced changes to the
get_batch_on_this_cp_rankfunction. This PR is updating M-Bridge to the new signature.Changelog
GitHub Actions CI
See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information