Repository navigation
[misc] feat: Add NVTX ranges for train_step and optimizer_step - #3198
Merged
cuichenx merged 1 commit intoJun 11, 2026
Merged
Conversation
minitu
changed the title
minitu
added
feature
minitu
changed the title
minitu
marked this pull request as ready for review
June 9, 2026 21:36
minitu
added
the
needs-review
minitu
force-pushed
the
jaeminc/nvtx-train-step-optimizer-ranges
branch
from
June 9, 2026 21:44
75b7e6b to
c06e867
Compare
Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
minitu
force-pushed
the
jaeminc/nvtx-train-step-optimizer-ranges
branch
from
June 9, 2026 21:48
c06e867 to
ae564c9
Compare
Contributor
|
/ok to test ae564c9 |
Contributor
|
/ok to test ae564c9 |
gautham-kollu
approved these changes
Jun 10, 2026
Contributor
|
CI passed except the flaky omni test https://github.com/NVIDIA-NeMo/Megatron-Bridge/actions/runs/27292747492/job/80722318034?pr=3198 |
cuichenx
disabled auto-merge
June 11, 2026 15:59
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add @nvtx_decorator() on train_step to emit an NVTX range named megatron.bridge.training.train.train_step, and add explicit nvtx_range_push/pop around the optimizer step block within train_step.
These ranges are gated by the nvtx_ranges profiling config and require the nvtx_decorator call-time fix in Megatron-LM (NVIDIA/Megatron-LM#4184).
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information