Repository navigation
fix(rollout): exclude compaction helpers from fallback turns - #5122
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
8c8c7b8 to
617a5c6
Compare
svcnvidia-nemo-ci
left a comment
There was a problem hiding this comment.
SHIP
LGTM — no concerns found.
Reviewed the collector changes and regression tests, tracing reference resolution, ownership validation, token accounting, and health consumers. The exclusion preserves captured calls and ownership claims without changing producer-provided trajectories or existing HTTP-error handling.
Static review only; tests were not executed.
Note: formal approval is not available for this request, so this review is posted as a comment only.
Review generated by codex. This was a full review. Request a full review with /review reset=true.
e042638 to
f54c236
Compare
f54c236 to
7606d05
Compare
Signed-off-by: Giulio Lovisotto <glovisotto@nvidia.com>
Signed-off-by: Giulio Lovisotto <glovisotto@nvidia.com>
Signed-off-by: Giulio Lovisotto <glovisotto@nvidia.com>
7606d05 to
a3c43dd
Compare
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/41797691599 |
Automatic compaction produces a model call for the summary, but the collector currently turns that helper response into an extra policy turn. Exclude uniquely resolved compaction helper references from fallback turn construction while retaining the calls, ownership and token usage. Keep helpers out of turns even when agent ownership claims conflict, preserving those claims for validation. This matches the verifier exclusion rule in #4630. Preserve producer-provided trajectories and the HTTP-error exclusion introduced in #4045.
Stack: this PR → shared support #5307 → Kilo/Codex/Stirrup/Hermes fixes → #5439, which registers the scenario last.
Earlier validation:
python -m pytest -q responses_api_agents/terminus_2_sandboxed_agent/tests --disable-warnings: 135 passed, 4 skipped with Harbor 0.22.0. Align the existing saved-projection test's fallback expectation with helper exclusion while preserving its assertions for producer decisions and command-batch counts (original contract). The earlier CI failure expected six rebuilt turns; only three are retained because three referenced compaction helpers are excluded.Prepared with Codex. Full repository CI is not yet validated.
Rebase validation — 2026-11-02
Rebased onto main
0c7ac5119c99e0aa0dfeda7be59157c589680ffd, preserving the existing stack order. The assembled original stack passed 1,719 shared conformance, collector, Codex and Kilo tests (16 skipped, 76 configuration-test cases deselected). The separate Terminus saved-projection suite passed all 30 tests. Fresh compaction rollouts retain 16 calls and 15 policy turns on OpenCode, Kilo, Codex, Stirrup and Hermes, including helper usage. All-file pre-commit passed on both stack tips; commits have DCO sign-off and SSH signatures. These are local pinned-runtime runs with a controlled provider, not remote deployment or full repository CI qualification.