Skip to content

fix(sandbox): reclaim owned session runtimes - #5088

Open
anson627 wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
anson627:anson627/kilocode-conformance-fixes
Open

fix(sandbox): reclaim owned session runtimes#5088
anson627 wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
anson627:anson627/kilocode-conformance-fixes

Conversation

@anson627

@anson627 anson627 commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Remove private session runtimes after artifact capture and confirmed cleanup, before stopping agent-owned sandboxes. Always stop the sandbox if removal fails. Task output and borrowed-session behavior are preserved.

Split from #4764 at review request; no separate issue is needed. Main now includes Kilo model-error handling, so this PR contains only shared runtime cleanup.

Verification:

  • 1,021 tests passed, 31 skipped, using the command below.
  • pre-commit run --all-files passed; private guardwords catalog unavailable.
  • Prior live evidence on harbor-dev (October 24): all 7 Kilo conformance scenarios passed. A real Qwen3.6 rollout completed; independent file verification and runtime cleanup passed, with task output preserved. This rebase did not repeat live model runs.
PYTHONPATH="$PWD" NEMO_GYM_EXTRA_ROOTS="$PWD" python -m pytest --import-mode=importlib tests/unit_tests/agents/test_sandbox_session.py responses_api_agents/kilocode_agent/tests/test_sandbox.py scripts/harness_conformance/tests tests/unit_tests/harness_capabilities responses_api_agents/codex_agent/tests/test_sandbox_sessions.py responses_api_agents/opencode_agent/tests/test_sandbox_sessions.py responses_api_agents/opencode_agent/tests/test_lifecycle_contract.py responses_api_agents/pi_agent/tests/test_sandbox.py -q -o addopts=''

@copy-pr-bot

copy-pr-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

anson627 added a commit to anson627/Gym that referenced this pull request Oct 26, 2026
@anson627
refactor(sandbox): split shared conformance repairs into separate PR
b94b1db 
Move shared owned-session cleanup and Kilo model-error handling to NVIDIA-NeMo#5088, as requested in review. Keep NVIDIA-NeMo#4764 focused on CoreWeave and its required dependencies, configuration and docs.

CoreWeave plus OSWorld resolver-policy checks: 67 passed, 1 skipped. All-file pre-commit passed; private guardwords catalog unavailable. The four removed conformance files now match upstream/main.

Signed-off-by: Anson Qian <1474346+anson627@users.noreply.github.com>
@nemo-automation-bot nemo-automation-bot Bot added the community-request Issue reported or requested by someone from the community label Oct 26, 2026
@anson627 anson627 mentioned this pull request Oct 26, 2026
Open
@svcnvidia-nemo-ci svcnvidia-nemo-ci added area:agent Agent harnesses and Responses API agent behavior bug Something isn't working labels Oct 26, 2026
@anson627
anson627 marked this pull request as ready for review October 26, 2026 17:08
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the blocked Work cannot move forward until an external dependency is cleared label Oct 26, 2026
@giuliolovisotto giuliolovisotto mentioned this pull request Oct 27, 2026
Merged
7 tasks done
@github-actions github-actions Bot added the sla:triage-overdue Review assignment is over the one-business-day SLA label Oct 27, 2026
@github-actions github-actions Bot mentioned this pull request Oct 27, 2026
Open
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-maintainers Waiting on maintainers to respond label Oct 28, 2026
@anson627
anson627 force-pushed the anson627/kilocode-conformance-fixes branch 2 times, most recently from 7b22ed1 to fe2ec78 Compare November 3, 2026 19:53
This was referenced Nov 4, 2026
Open
Open
@anson627
anson627 force-pushed the anson627/kilocode-conformance-fixes branch from fe2ec78 to c82b270 Compare November 4, 2026 17:33
@svcnemo-autobot svcnemo-autobot mentioned this pull request Nov 4, 2026
Open
@yaoyu-33

yaoyu-33 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

/ok to test c82b270

@svcnemo-autobot svcnemo-autobot mentioned this pull request Nov 5, 2026
Merged
@nemo-automation-bot
nemo-automation-bot Bot requested review from a team November 5, 2026 00:44
@yaoyu-33 yaoyu-33 mentioned this pull request Nov 5, 2026
Open
@svcnemo-autobot svcnemo-autobot mentioned this pull request Nov 5, 2026
Merged
@anson627
fix(sandbox): reclaim owned session runtimes
9fb31bb 
Remove private session files after capture and confirmed cleanup, before stopping owned sandboxes. Always stop the sandbox if runtime removal fails; preserve task output and borrowed-session behavior. Main now contains the Kilo model-error handling, so this PR retains only the shared runtime cleanup fix.

Signed-off-by: Anson Qian <1474346+anson627@users.noreply.github.com>
@anson627
anson627 force-pushed the anson627/kilocode-conformance-fixes branch from c82b270 to 9fb31bb Compare November 5, 2026 04:04
@anson627 anson627 changed the title fix(kilocode): preserve model errors and clean up owned runtimes fix(sandbox): reclaim owned session runtimes Nov 5, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci removed the waiting-on-maintainers Waiting on maintainers to respond label Nov 5, 2026
@yaoyu-33

yaoyu-33 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

/ok to test 9fb31bb

@yaoyu-33
yaoyu-33 enabled auto-merge November 6, 2026 23:17
@nemo-automation-bot
nemo-automation-bot Bot requested review from a team November 6, 2026 23:18
@github-actions github-actions Bot removed the sla:triage-overdue Review assignment is over the one-business-day SLA label Nov 6, 2026

This branch was previously deployed

1 inactive deployment
public — 9fb31bbc Deployed Nov 6, 2026 by copy-pr-bot[bot] via release / finalize / notify #10771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaoyu-33 yaoyu-33 yaoyu-33 approved these changes

Assignees

No one assigned

Labels

area:agent Agent harnesses and Responses API agent behavior blocked Work cannot move forward until an external dependency is cleared bug Something isn't working community-request Issue reported or requested by someone from the community

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anson627 @yaoyu-33 @svcnvidia-nemo-ci