Repository navigation
fix(harbor-agent): restore the pathspec runtime dependency - #5040
jackiectl2 wants to merge 2 commits into
Conversation
Keep pathspec available to the Harbor server despite the root override that removes it from other environments. Fixes NVIDIA-NeMo#4517 Signed-off-by: Tianlang (Jackie) Chen <305351710+jackiectl2@users.noreply.github.com>
|
Thanks for the fix. The branch is 128 commits behind main, so I checked it as your commit cherry-picked onto current
Outside this PR: LGTM from the QA side. |
|
/ok to test e9cb672 |
|
Could you please share ETA for PR? |
Signed-off-by: Tianlang (Jackie) Chen <305351710+jackiectl2@users.noreply.github.com>
|
Thanks for checking in. I have updated the branch to current main in d367b2b. The Harbor agent now restores |
What does this PR do?
The root dependency override excludes
pathspec, butharbor.jobimports it through its directory-scanning dependencies. The Harbor agent must restorepathspecin its own environment. The current server usespyproject.tomlanduv.lock, so this PR pinspathspec==1.1.1there and overrides the root exclusion for that server. The import regression test remains in the Harbor agent tests.Fixes #4517.
Validation
ModuleNotFoundError: No module named 'pathspec'while importingharbor.job. With the original requirements/overrides fix, that import test passed; a maintainer also reported 123 server-environment tests passing on the cherry-picked change.pyproject.toml,uv lock --directory responses_api_agents/harbor_agentresolved 221 packages.uv tree --lockedanduv export --locked --no-devboth show activepathspec==1.1.1for this server. The lock changed only the relevant dependency markers and entries.pre-commit run --fileson the Harbor project manifest, lockfile and import test passed.compileallon the import test andgit diff --checkon changed Harbor files passed.Rollouts
N/A for this dependency manifest fix. No model rollout was run.
Compatibility and benchmark impact
The Harbor agent environment gains
pathspec==1.1.1; other server environments retain the root exclusion. Benchmarks were not run.Checklist
git commit -s).