Repository navigation
feat(enterpriseops): add external MCP benchmark integration - #4944
Draft
d-molinari wants to merge 1 commit into
Draft
d-molinari wants to merge 1 commit into
d-molinari wants to merge 1 commit into
Conversation
Extract the EnterpriseOps integration from 0f4aa2c738b1694bf1c020db5a7ef0bfe204e440 onto main. Preserve pinned oracle preparation, trusted external MCP endpoints, strict and parity scoring, cleanup retries, optional per-turn telemetry, and historical runtime evidence. Add current task-data and environment-server contracts plus the janitor/reseed race guard. Signed-off-by: Daniele Molinari <dmolinari@nvidia.com>
7 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds our standalone EnterpriseOps-Gym integration to current
main, extracted from0f4aa2c738b1694bf1c020db5a7ef0bfe204e440ondmolinari/officegenand based on9334fa27c53d2e35e1242bb9661fad605dc8cc84.The integration runs the pinned 649-task public oracle split across eight domains through Gym agents, a resources server that seeds per-rollout databases and proxies MCP tools, and the upstream SQL/judge verifier semantics. It includes benchmark preparation, trusted endpoint/replica configuration, cleanup retries, tool-schema snapshots, an optional per-turn telemetry agent, and runtime/provenance documentation.
This is the external-service variant: operators run the seven pinned MCP containers and configure
seed_sql_rootand trusted endpoints. Related #2142 develops managed sandbox startup. The focused cleanup contribution in #4774 remains targeted at that PR's branch. This separate main-based draft makes our complete implementation available for review; no separate issue is needed for this extraction.Main-branch compatibility additions include the task-data schema, explicit environment-server declarations, explicit non-Ray runtime declarations, and the janitor/reseed race guard from #4774.
Validation
gym eval prepare --benchmark enterpriseops: 649 rows prepared from dataset revisionc8e538eae8a6205294f0a86675fefdc1fac408f6; exact counts: calendar 61, CSM 103, drive 64, email 67, HR 102, ITSM 103, teams 61, hybrid 88. All 649 rows pass task-data validation with no unknown, conflicting, or misplaced fields.gym env test +entrypoint=resources_servers/enterpriseops_gym +should_validate_data=true +skip_venv_if_present=true: 52 passed, example-data validation passed.gym env test +entrypoint=responses_api_agents/turn_logging_agent +should_validate_data=true +skip_venv_if_present=true: 4 passed.apex_shortlist/hlesandbox configurations; it passes with a test-process-only host-resolution override to a documentation address. No DNS or repository workaround was committed.error_on_agent_without_environment_server=true, using a placeholder model config and no inference.pre-commit run --all-filesandgit diff --check: passed. The private guardwords hook reported its catalog unavailable and skipped its scan.uv sync --locked --extra dev; each server has its own environment. DCO sign-off is included. Full repository CI has not been run locally.Rollouts
Fresh real-model smokes on 2026-10-22 used
azure/openai/gpt-5-mini, temperature 0, a 30-step cap, and an 8,192-token per-response cap against the existing real CSM Docker service through this integration's configured endpoint and SQL seed root.Both runs used public example
task_20251205_153330_906_a8eea1c0_8c7a6205:simple_agentturn_logging_agentThe inspected trajectories update the entitlement, create the critical case with the expected assignment, and link its resolution SLA. SQL verification confirms the resulting state. Both runs also injected a first deletion failure: the database handle was retained, then the real janitor deletion succeeded and removed the session.
These are two rollout executions of one task, not a full-benchmark evaluation. Existing parity/performance/RL-pilot reports retain their historical provenance and were not rerun for this draft.
Compatibility and benchmark impact
No existing environment is replaced. The new configs retain
verified: false. Reward defaults to upstream name-collapsed parity scoring; strict every-verifier metrics are emitted separately and can be selected for reward. Task preparation remains pinned and writes its output atomically. The large JSON portion of the diff consists primarily of seven public tool-schema snapshots; the full 649-task benchmark is downloaded at prepare time and is not committed.Draft review follow-ups include the optional telemetry agent's divergence from current
SimpleAgentcookie merging/no-tool termination, whether to use native trajectory capture instead, and runtime enforcement of selected/restricted tools beyond conversion-time filtering. The external service deployment choice also needs review alongside #2142.Checklist