Repository navigation
Conversation
Signed-off-by: Daniele Molinari <dmolinari@nvidia.com> (cherry picked from commit 7520e38) Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional EnterpriseOps telemetry agent loses its resource-session cookie when a tool returns no
Set-Cookie, and keeps generating after a completed response contains only reasoning or no output. Partial database-seeding failures also leave successful sibling databases without a cleanup owner. This follow-up fixes those paths and the parent PR's failing config/test integration.Targets the head branch of #2142 so the fixes can be incorporated before that benchmark merges. A separate issue is unnecessary: these are reproduced findings from that PR's review.
Changes
/verify. Stop reasoning-only/empty responses using the existing SimpleAgent termination semantics while retaining turn telemetry and usage.7520e387a), preserving its author and sign-off: wait for all seed attempts, retain failed deletions for retry, and prevent reseeding from discarding database handles.httpx2==2.13.1path.The default SimpleAgent and SQL scoring formulas are unchanged. The optional telemetry agent now stops invalid terminal generations instead of making extra model calls. Reseeding after a failed cleanup reports an error rather than losing the outstanding database handles.
Validation
All checks ran against the final diff on Python 3.13.14:
gym env test +entrypoint=resources_servers/enterpriseops_gym +should_validate_data=true +skip_venv_if_present=true: 115 passed, 1 skipped, example-data validation passed. Ran with locked dependencies and again with CI'shttpx2==2.13.1; both passed. The skip is the optional tool-snapshot checksum check because snapshots were not prepared.gym env test +entrypoint=responses_api_agents/turn_logging_agent +should_validate_data=true +skip_venv_if_present=true: 7 passed.python -m pytest -q -o addopts= --import-mode=importlib tests/unit_tests/test_ray_opt_out.py tests/unit_tests/test_add_legacy_agent_environment_servers.py tests/unit_tests/test_apptainer_provider.py: 140 passed, including all three previously failing root integration tests.pre-commit run --all-filesandgit diff --check: passed. All commits include DCO sign-off.Rollout evidence
An integration smoke against the exact pinned CSM Docker image advertised 89 tools, seeded the native example database, and successfully queried its 18 tables. Injecting a first deletion failure retained the database handle; the subsequent janitor pass performed the real deletion and removed the session. This validates the service and cleanup path, but is not a model rollout.
Draft pending a representative real-model smoke, as required by
AGENTS.md. The saved model configuration returns HTTP 401 on both model discovery and a minimal inference request; no model rollout completed on this diff. The older full-benchmark run is not counted as validation of these changes. Managed Apptainer startup has not been revalidated by this follow-up.