Repository navigation
feat(nooa): add a canonical GDPval recipe - #4821
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test f4f26df |
|
🌿 Preview your docs: https://nvidia-preview-pr-4821-af4a32ac815b.docs.buildwithfern.com/nemo/gym |
init-nikhil
left a comment
There was a problem hiding this comment.
CODEX SELF REVIEW
Reviewed head f4f26df2c19a433fb7de44d3f97aa225bb6a9924 against actual stacked base 10b5752d81c6c5098f1dc48cf35c21b4a81b571e with the official Codex CLI 0.154.0 (gpt-6-astra, fresh read-only review process). No actionable findings were returned.
The engine performed static source inspection; it did not execute tests. Local, live-model, and CI validation are tracked separately. This is not a readiness or correctness guarantee.
|
/ok to test 7f2a164 |
init-nikhil
left a comment
There was a problem hiding this comment.
CODEX SELF REVIEW
Reviewed head 7f2a164947f2acca32f5a8734b07c1080e390d47 against actual stacked base 15e0fb21f83dfc8879ed1ef74e595f91044d94e4 with official Codex CLI 0.154.0 (gpt-6-astra, fresh read-only review process).
No actionable findings were returned.
The engine performed static source inspection; it did not execute tests. Model, benchmark and CI validation are tracked separately.
|
/ok to test f5ae09c |
init-nikhil
left a comment
There was a problem hiding this comment.
CODEX SELF REVIEW
Reviewed head f5ae09ce24e13d77cff23c62b71e7ba0fff0c5f2 against actual stacked base 5f686c347465e2041335ea46153eba463b60bb4f with official Codex CLI 0.154.0 (gpt-6-astra, fresh read-only review process).
No actionable findings were returned.
The engine performed static source inspection; it did not execute tests. Model, benchmark and CI validation are tracked separately.
Propagate existing reviewed parent changes while preserving the authored layer and branch history. Signed-off-by: Nikhil Deshmudre <nikhil.deshmudre@gmail.com>
Integrate the prepared stack parent while preserving this PR's authored changes. Signed-off-by: Nikhil Deshmudre <nikhil.deshmudre@gmail.com>
a489027 to
bb9b217
Compare
bb9b217 to
fe3191c
Compare
Signed-off-by: Nikhil Deshmudre <nikhil.deshmudre@gmail.com>
fe3191c to
af4a32a
Compare
|
/ok to test af4a32a |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/41766410424 |
Current stack revision — November 3, 2026
Head:
af4a32ac815b71eee5007e43d84baf28a699a7f4. Stack refreshed onto main3880fa5024bf97199cba96ade2e0fa6ec9eb6fbfwith current import locations and merge conflicts resolved. Each PR remains a separate layer; landing uses native stack merge.#4088 now packages the launching Gym checkout using its unchanged root
pyproject.tomland full core dependencies. The separateresponses_api_agents/nooa_agent/runtime/pyproject.tomlwas removed. Tracked source and package assets are copied with their current contents; untracked files, Git metadata, and caches are excluded. This requires Git on the controller. Sandbox installation stays in its private Python, and source changes invalidate prepared offline wheelhouses. #4813 retains its workflow change and code-owner review requirement.Validation: 87 focused runtime, offline-bundle, and task-network-policy tests passed after the refresh; all-files pre-commit passed (private guardword catalog unavailable). A real Gym wheel built successfully from the new archive format, and its NOOA entrypoint, resource dispatcher, and core package asset were verified. No model rollout or Linux installation was run for this packaging change. Earlier evidence below is historical and does not establish fresh results for this head.
GitHub dismissed earlier reviews after this update; current-head reviews and required CI are still needed.
Stack refresh — 2026-11-02
Current head:
bb9b21707ea8d54f3406e2151cf5ac79fee729a3. Stack refreshed onto main2b8efc987af03951a80f941f2a278317badfe085. This PR remains a separate layer in the intended stack merge: #4088 → #4820 → #4821 → #4351 → #4357. #4813 is excluded.Reconstructed each layer from its final reviewed patch instead of replaying foundation commits already merged into main. Resolved current package-import and legacy-environment renames while retaining upstream checkpoint handling and newer harness support. #4088 also exports its networking helpers through the current public API and mechanically updates existing callers; #4351 exports its newly used response types.
Fresh validation on the combined refreshed stack:
19caab169b018476ac433d040f6ae3f06aeff101.pre-commit run --all-files: passed, including package layering, guardwords, lint and format.No fresh real-model benchmark was run for this conflict/import refresh. Prior live-rollout evidence below is historical. Fresh reviews and required GitHub CI remain outstanding; this is not a merge-readiness claim.
Earlier implementation and validation (before this refresh)
Tests and validation
Head
bc6a7e7976b29e08af1d9986489c2aabcdeea82c; base9b9c186321d0defb19f1e10edf16150bfb1a9ee4. The existing stack tracks this work; no separate issue is needed.40 metrics/core checks and the standalone canonical recipe fixture passed. Three focused metrics/recipe tests and independent CLI/comparator probes also passed: Stirrup-to-NOOA and reverse source reuse work, source bytes remain unchanged, and source-statistics/rendered-template conflicts are still detected.
One fresh canonical Property Manager task
1e5a1d7f-12c1-48c6-afd9-82257b3f2409using policy modelopenai/openai/gpt-5.5completed through the real CLI, GDPval resources server, Docker sandbox, NOOA policy,finish(reason, paths)and nativeTaskResult. Eight distinct policy response IDs were recorded. The canonical rubric workflow sampled GPT-5.5 and returned 0.96, with a gradable row and no infrastructure or cleanup failure. The submittedPM_Weekly_Task_Schedule.docxpassed structural readback and a visual check of its two-page rendering; the task container, services and temporary controller were removed.The sanitized evidence bundle contains the report, recorded commands, resolved nonsecret settings, deliverable and previews. Upload and metadata readback in the shared NeMo Gym Drive were verified; individual recipient access was not tested.
Reproduce on this revision with the task extracted from the canonical dataset and a private overlay containing reachable model/judge endpoints, credentials and
judge_media_mode=images_and_text. The evidence bundle records the original command arguments and resolved nonsecret values; the command below substitutes portable filenames for those run-local paths:gym env start --config benchmarks/gdpval/nooa.yaml \ --config responses_api_models/vllm_model/configs/vllm_model.yaml \ --config private-overlay.yaml gym eval run --no-serve --config benchmarks/gdpval/nooa.yaml \ --config responses_api_models/vllm_model/configs/vllm_model.yaml \ --config private-overlay.yaml --input gdp-pm-schedule-original.jsonl \ --output rollouts.jsonl --limit 1 --concurrency 1 --num-repeats 1 \ --agent gdpval_nooa_agent \ --prompt-config benchmarks/gdpval/prompts/harness-neutral.yamlThe run used an explicit one-task input and
judge_media_mode=images_and_texton arm64; the shipped--split benchmarkrecipe was checked separately. Only GPT-5.5 was sampled from the canonical judge panel. Web-search authentication, x86_64 parity and the full suite were not validated. Persisted per-call/turn objects were unavailable, and fallback terminal output is explicitly non-trainable. This fresh 0.96 result is separate from the historical 0.95 run.pre-commit run --all-filespassed. Fresh official Codex review returned no actionable findings; the independent bug hunt passed for this head and base.CI snapshot (2026-10-24 05:44 UTC) on this head: 9 checks remain pending. Current checks. The all-green readiness gate remains unmet; no final verification-success post or new review request is implied.