Repository navigation
Conversation
Preferring the agent-session interface for every adapter that implements session setup and close removed the P0 signal for all four registered harnesses: the session path is not yet conformant for any of them, so main has been red on Harness conformance since that change. Make the /run path the default again and keep the session path as an explicit opt-in, --agent-interface sessions, on the runner and the episode. Requesting sessions for an adapter without session hooks is an execution error. The default can move to sessions once the registered adapters pass P0 through it. Signed-off-by: Davanum Srinivas <dsrinivas@nvidia.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Harness conformance P0 on
mainhas been red for all four harnesses since #4489 made the agent-session interface the default for every adapter that implements session setup and close. The session path is not yet conformant for any registered adapter: terminal model errors become failure sidecars instead of rollouts (opencode, codex, pi), codex rollouts have no turns, hermes and pi fail the ownership checks, and opencode fails the sandbox identity check. The P0 check and the published table therefore measure nothing.This makes the
/runpath the default again and keeps the session path as an explicit opt-in,--agent-interface sessions, on the runner and the episode. Requesting sessions for an adapter without session hooks is an execution error. The default can move to sessions once the registered adapters pass P0 through it.Validation
On Linux x86_64 at this branch's base (ac51e85), the same tests plus the four adapter test directories (1580 passed, 9 environment skips), then the default probes:
opencode, hermes, codex and pi each exit 0 with all seven scenarios fulfilled, the result
mainhad before #4489. The opt-in path still runs:pi and hermes exit 0 with
agent_interface: agent_sessionsinruntime.json.Rollouts
No environment or agent code changes. The Linux runs above produced one conformance report per harness with seven fulfilled scenarios each.
Compatibility and benchmark impact
CI probes return to the
/runpath.suite.jsonrecords the selectedagent_interface. The rerun commands in the P0 check stay valid. No benchmark impact.Checklist
pre-commit run --all-files) (so CI lint/format checks pass).git commit -s) (so the DCO check passes).