Repository navigation
fix(ether0): gitignore the auto-installed checkout - #4606
Merged
Merged
Conversation
The ether0 resources server clones the upstream ether0 repository into
resources_servers/ether0/.ether0/ the first time its tests or server start.
That directory was not ignored, so it showed up as untracked after a test run.
The clone also carries .github/workflows/lint-test.yaml. The core unit test
test_all_repo_configs_load_without_duplicate_keys loads every *.yaml under
resources_servers/ with OmegaConf, and GitHub Actions expressions such as
${{ matrix.python }} fail to parse. Any checkout where the ether0 tests had run
therefore failed the core unit suite.
Add .ether0/ to a per-server .gitignore, following chemcotbench. Make the
config sweep skip YAML files under hidden directories inside the swept trees,
since those hold local tool checkouts rather than Gym configs, and add a test
that a workflow file under a hidden directory is not collected.
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ananthsub
marked this pull request as ready for review
October 14, 2026 17:35
yaoyu-33
added
area:ci
cmunley1
approved these changes
Oct 15, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/38697834060 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/38699487540 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The ether0 resources server clones the upstream ether0 repository into
resources_servers/ether0/.ether0/the first time its tests or server start (ensure_ether0()inresources_servers/ether0/setup_ether0.py). That directory was not covered by any.gitignore, so it showed up as untracked after a test run.The clone also includes
.github/workflows/lint-test.yaml. The core unit testTestConfigLoadErrors::test_all_repo_configs_load_without_duplicate_keysintests/unit_tests/test_global_config.pyloads every*.yamlunderresources_servers/with OmegaConf. OmegaConf cannot parse GitHub Actions expressions such as${{ matrix.python }}, so the test failed withtoken recognition error at: '{'. As a result, the core unit suite failed on any checkout where the ether0 tests had run.The fix has two parts:
resources_servers/ether0/.gitignoreignores.ether0/. This follows the per-server convention thatchemcotbenchuses for its.upstream/and.molopt/checkouts, and matches the AGENTS.md guidance that auto-installed tools live in a gitignored.<tool_name>/prefix inside the server directory.No issue is linked because this is a small test-environment fix with no user-facing behavior change.
Validation
pytest tests/unit_tests/test_global_config.py -xgym env test --resources-server ether0, which cloned.ether0/with its workflow file. Afterwardsgit statusdid not list.ether0/, andpytest tests/unit_tests/test_global_config.pypassed. The same config-load test frommainfails on that checkout with thetoken recognition errorabove.pre-commit run --files resources_servers/ether0/.gitignore tests/unit_tests/test_global_config.pyRollout evidence
N/A. The change touches only a
.gitignoreentry and a unit test's file discovery, and it does not change environment, agent, or verifier behavior.