Repository navigation
docs(ifbench): drop --prompt-config from the README eval example - #4538
Merged
ananthsub merged 1 commit intoOct 12, 2026
Merged
Conversation
The README's `gym eval run` passed `--prompt-config
benchmarks/ifbench/prompts/default.yaml` together with
`--input resources_servers/ifbench/data/example.jsonl`. Every example row
already carries `responses_create_params.input`, and
`validate_prompt_compatibility` rejects that combination, so the documented
command failed on rows [0, 1, 2, 3, 4] before any generation.
Each shipped `input` is exactly what `default.yaml` (`user: "{prompt}"`)
renders from the row's `prompt`, so dropping the flag leaves the model
input unchanged. The data and the validation stay as they are.
NVBug: 6783016
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: qiaochuz <qiaochuz@nvidia.com>
Contributor
Author
|
/ok to test 07b4ac2 |
Contributor
|
🌿 Preview your docs: https://nvidia-preview-pr-4538-07b4ac277a8f.docs.buildwithfern.com/nemo/gym |
ananthsub
approved these changes
Oct 12, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/38296457509 |
ananthsub
deleted the
qiaochuz/nvb-6783016-ifbench-readme-prompt-config
branch
October 12, 2026 19:27
Contributor
Author
|
Retrospective QA-fix tracking issue: #4700 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
gym eval runexample inresources_servers/ifbench/README.mdnow runs. It passed--prompt-config benchmarks/ifbench/prompts/default.yamltogether with--input resources_servers/ifbench/data/example.jsonl, but every example row already carriesresponses_create_params.input.validate_prompt_compatibility(nemo_gym/prompt.py:76-86)rejects that combination on purpose, so the documented command failed on all five rows before any
generation.
Fixes NVBug 6783016 (Jira NMGYM-57).
Cause
example.jsonlis pre-rendered, and the README asked Gym to render the prompt a second time. Themismatch dates from #999, which added IFBench with pre-rendered rows and an
ng_collect_rollouts +prompt_config=...example after the validation (#861) already existed. #1630 carried the flagover into the
gym eval runform.Fix
Remove
--prompt-config(and the trailing\before it) from the README command. The data and thevalidation stay as they are:
example.jsonlmust keepinput: it is thetype: exampledataset ofifbench_simple_agent(
resources_servers/ifbench/configs/ifbench.yaml), which has no prompt config.inputis exactly
[{"role": "user", "content": <prompt>}], which is whatdefault.yaml(
user: "{prompt}") renders.--benchmark ifbenchpath is unaffected:benchmarks/ifbench/prepare.pywrites rows withoutinput, matching theprompt_configinbenchmarks/ifbench/config.yaml.Before the fix
Gym
eed77e195(main), the README command against the README'sgym env start --benchmark ifbench --model-type openai_model:gym eval run --no-serve \ --agent ifbench_benchmark_simple_agent \ --input resources_servers/ifbench/data/example.jsonl \ --output /tmp/ifbench_rollouts.jsonl \ --num-repeats 1 \ --max-output-tokens 4096 \ --temperature 0.0 \ --prompt-config benchmarks/ifbench/prompts/default.yamlAfter the fix
Gym
07b4ac277(this branch), the README command as now documented, same environment:gym eval run --no-serve \ --agent ifbench_benchmark_simple_agent \ --input resources_servers/ifbench/data/example.jsonl \ --output /tmp/ifbench_rollouts.jsonl \ --num-repeats 1 \ --max-output-tokens 4096 \ --temperature 0.0Validation
testcases/environments/ifbench.py(nmfw_tests), which runs the README's owncommands with a live
openai_modelbackend on an H100 host:eed77e195: 0/1 passed (theValueErrorabove);07b4ac277: 1/1 passed — five real generations, verify results recomputedindependently, and twelve strict/loose/fractional/binary scoring controls.
--prompt-configreads all five rowsand gets past preprocessing; with it, the same
ValueError.pre-commit run --all-files: passed.pytest tests/unit_tests/test_fern_docs_links.py tests/unit_tests/test_cli_main.py: 243 passed.Compatibility
None. Documentation only; no code, config, or data changes.
🤖 Generated with Claude Code