Repository navigation
Conversation
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 12, 2026 21:53
04804ff to
df592e9
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 12, 2026 21:57
df592e9 to
7e828a1
Compare
This was referenced Oct 12, 2026
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 13, 2026 16:24
7e828a1 to
bc000e6
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
2 times, most recently
from
October 13, 2026 20:27
03e0349 to
2f563ae
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 13, 2026 20:45
2f563ae to
9665a00
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 14, 2026 08:05
9665a00 to
d3e1f94
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 14, 2026 15:30
d3e1f94 to
b7a7e19
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 14, 2026 17:24
b7a7e19 to
65f68ba
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 15, 2026 19:48
b925d6c to
c49ff45
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 15, 2026 20:03
c49ff45 to
7a6340e
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 15, 2026 20:30
7a6340e to
f464f9d
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 16, 2026 00:17
f464f9d to
1c79fe9
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 16, 2026 08:40
1c79fe9 to
a192974
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
2 times, most recently
from
October 20, 2026 07:51
dc39546 to
d341604
Compare
This was referenced Oct 20, 2026
Draft
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
2 times, most recently
from
October 20, 2026 22:18
c526f2d to
d36ba57
Compare
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 21, 2026 03:04
d36ba57 to
501a150
Compare
7 tasks done
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 25, 2026 02:47
501a150 to
52c1a6e
Compare
…pture ledger A harness interrupted at a checkpoint (OpenCode killed while its model call is held) gives up on the call. The ledger had recorded it, often as a failure row for a request that ended without staging coordinates, and the gate no longer counted it as undelivered once the request had finished, so the row went into the commit and the restored attempt's manifest reported a failure for a call no trajectory contains, which masks the sample. The policy gate now remembers calls whose client left while admission was closed (`GateSnapshot.abandoned`); the commit leaves their rows out like an undelivered call's, and the resume drops them from the live ledger (`FileLineageStore.discard_calls`), in the single-process and the multi-worker policy server alike. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Pranav Prashant Thombre <pthombre@nvidia.com>
pthombre
force-pushed
the
pthombre/partial-ckpt-sandbox-capture
branch
from
October 25, 2026 16:57
52c1a6e to
912ce78
Compare
7 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
A harness that gives up on a model call while a checkpoint holds it abandons that call. Examples are OpenCode stopped at a checkpoint (the fallback when a pause cannot be confirmed, #4274) and a run cancelled while its call is held.
With token capture on, the ledger had already recorded the call, often as a failure row for a request that ended without staging coordinates. Once the request had finished, the policy gate no longer counted it as undelivered, so the row went into the commit. The restored attempt's manifest then reported a failure for a call that no trajectory contains, which masks the sample.
What this PR adds:
PolicyGate.abandoned, carried inGateSnapshot.abandoned).FileLineageStore.discard_calls).model_workers.py).With #4274's pause-at-checkpoint, OpenCode keeps its held call across an in-job checkpoint and reads the reply on continue, so in-job checkpoints rarely abandon a call now. This PR still covers the stop fallback, cancelled runs, and any harness that does not pause.
How it works
Where this sits in the stack
Stack #4578, on
ananthsub/partial-ckpt-fault-tests:release, snapshot index, sandbox leaseThe change itself touches only the policy model participant and the capture ledger, independently of the sandbox work below it. It is stacked here because the OpenCode run in #4274 is what exposes it. The patch is unchanged from the previous head; only its base moved.
Issue
No tracking issue.
Validation
On this head (
c526f2d06; its tree is identical tod3416046a, tested in therl-gym.nightlycontainer on Slurm, job 8085409):ruffis clean, and the commit carriesSigned-off-by.The test for this change:
tests/unit_tests/test_checkpoint_model.py::test_a_call_abandoned_while_held_is_left_out_of_the_commit_and_dropped_at_resume. A call held at prepare whose client leaves is excluded from the commit's records, and is gone from the live ledger after the resume.Earlier, on the previous head (the series tip rebased on
ananthsub/partial-ckpt-fault-tests6f3184eaf, jobs 1246655 and 1246856): checkpoint 758 passed, provider 145, sandbox 211, every pilot passed, and e2e 68 passed.Rollout evidence
Earlier capture-enabled cell-5 run (job 1186019; scenario B, rows 40–47,
TOKEN_CAPTURE=1behind a staging shim):32-node runs with the whole stack (jobs 8093570 on the current stack, and earlier 8078235 and 8080199 → 8081456; details in #4274):
Compatibility
None. Only calls abandoned while admission was closed are affected, and they never belonged in a commit.
🤖 Generated with Claude Code