Repository navigation
Conversation
Under load, reconnecting to a sandbox by id can time out. That call had no retry, so one timeout failed the rollout with a 500 and stopped the eval run. Retry it with the existing create retry settings. A missing sandbox (404) still fails at once. Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
Port the reconnect retry onto main's connect, which now also health-checks and cleans up. The cleanup-stall test pins retries to 0 because it tests a single attempt. Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
This was referenced Oct 22, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
OpenSandboxProvider.connectnow retries when reconnecting to a sandbox times out.Why
The OpenCode sandboxed agent reconnects to its sandbox by id at the start of a rollout. Under heavy load, with about 1000 sandboxes at once, that call sometimes times out with
TimeoutError: [Errno 110] Connect call failed./run, and the whole eval run stopped. We saw this on SWE-bench Pro on two clusters.Reconnecting only reads, so trying again is safe.
How
create.retries,retry_delay_s,retry_max_delay_s) and the same retryable-error check._connect_once.Branch shape
The first commit sits on
1e668906, because evals pinned there need the fix on that lineage. A merge from main follows it, so the PR applies cleanly. The net change to main isprovider.pyplus the tests.Tests
test_connect_preserves_failure_when_cleanup_stallsnow setsretries: 0, since it tests a single attempt.test_opensandbox_provider.pyandtest_opensandbox_pty.py: 200 passed.