Skip to content

feat(gdpval): add optional judge failure telemetry - #3960

Open
Kh4L wants to merge 1 commit into
NVIDIA-NeMo:gdpval-develfrom
Kh4L:spanev/gdpval-judge-failure-telemetry-devel
Open

Kh4L wants to merge 1 commit into
NVIDIA-NeMo:gdpval-develfrom
Kh4L:spanev/gdpval-judge-failure-telemetry-devel

Conversation

@Kh4L

@Kh4L Kh4L commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

GDPVal currently prints transient judge failures such as HTTP 429 responses, but loses the request shape and whether a later retry recovered. This adds opt-in structured telemetry through judge_telemetry_output_dir, recording preflight exclusions, individual provider failures, retry recovery, invalid responses, and terminal matchup failures.

Each resources-server process writes its own JSONL file. Failure events include the task/reference/judge identity plus the actual transmitted file labels, types, counts, attachment sizes, request size, and transport limits. Compact completion events provide the denominator needed to calculate failure and recovery rates. Prompts, attachment contents, base64 payloads, credentials, and absolute paths are excluded, and telemetry write failures never affect judging.

The included summarizer reports failure classes, HTTP statuses, recovery and terminal-failure rates, preflight reasons, request-size buckets, judges, tasks, and file extensions:

python -m resources_servers.gdpval.judge_telemetry /path/to/judge_telemetry

Judging behavior, retries, routing, scoring, and ELO fitting are unchanged when telemetry is disabled or enabled.

Validation:

  • 152 affected GDPVal tests passed on gdpval-devel
  • scoped pre-commit hooks passed

Signed-off-by: Serge Panev <spanev@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaoyu-33 yaoyu-33 added area:environment Individual environments, benchmarks, verifiers, and environment-specific resources servers complexity:medium Single-domain change with interacting parts or a moderate review surface feature New capabilities, enhancements, or enablement work needs-review PR is ready for code review and waiting on a reviewer labels Oct 2, 2026
@github-actions github-actions Bot added the sla:triage-overdue Review assignment is over the one-business-day SLA label Oct 5, 2026
khazic pushed a commit to khazic/Gym-lao that referenced this pull request Oct 6, 2026
GDPVal currently prints transient judge failures such as HTTP 429
responses, but loses the request shape and whether a later retry
recovered. This adds opt-in structured telemetry through
`judge_telemetry_output_dir`, recording preflight exclusions, individual
provider failures, retry recovery, invalid responses, and terminal
matchup failures.

Each resources-server process writes its own JSONL file. Failure events
include the task/reference/judge identity plus the actual transmitted
file labels, types, counts, attachment sizes, request size, and
transport limits. Compact completion events provide the denominator
needed to calculate failure and recovery rates. Prompts, attachment
contents, base64 payloads, credentials, and absolute paths are excluded,
and telemetry write failures never affect judging.

The included summarizer reports failure classes, HTTP statuses, recovery
and terminal-failure rates, preflight reasons, request-size buckets,
judges, tasks, and file extensions:

```bash
python -m resources_servers.gdpval.judge_telemetry /path/to/judge_telemetry
```

Judging behavior, retries, routing, scoring, and ELO fitting are
unchanged when telemetry is disabled or enabled.

Ports NVIDIA-NeMo#3960 from `gdpval-devel` to main; it applies without conflicts.

Validation:
- `resources_servers/gdpval/tests`: 570 passed on main `10b38dbfd` plus
this change
- `ruff check` and `ruff format --check` clean

Signed-off-by: Serge Panev <spanev@nvidia.com>
Co-authored-by: Marta Stepniewska-Dziubinska <marta-sd@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:environment Individual environments, benchmarks, verifiers, and environment-specific resources servers complexity:medium Single-domain change with interacting parts or a moderate review surface feature New capabilities, enhancements, or enablement work needs-review PR is ready for code review and waiting on a reviewer sla:triage-overdue Review assignment is over the one-business-day SLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants