Repository navigation
feat(nooa): use standard single-agent-turn sessions - #3846
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
86313d0 to
0b49742
Compare
1b8b381 to
678ea2b
Compare
678ea2b to
b986f5a
Compare
b986f5a to
04afd80
Compare
1fc04d9 to
65b82da
Compare
done, thanks for catching this. |
58ac533 to
a0392ec
Compare
|
/ok to test a0392ec |
a0392ec to
781d07c
Compare
yaoyu-33
left a comment
There was a problem hiding this comment.
Rechecked at 781d07c. Cleanup failures after genuine iteration exhaustion now remain fatal and skip verification; normal limits remain gradable. The exact-head NOOA suite passed: 194 tests. No blocking issue found in this layer; full CI is still outstanding.
|
/ok to test 781d07c |
Run one retry-safe NOOA activation per native session. Use the existing SingleAgentTurnEnvironmentServer for verification, rewards, episode deadlines and cleanup; return evidence and resource cookies at close. Remove the NOOA-specific environment, finish endpoint and legacy run route. Declare the standard environment and example routing explicitly. Instantiate each runner during agent-session seeding and keep ownership solely in session state, including reuse on idempotent seed retries. Return tool HTTP errors outside 5xx as model-visible feedback while retaining fatal handling for 5xx and transport failures. Signed-off-by: Nikhil Deshmudre <nikhil.deshmudre@gmail.com>
yaoyu-33
left a comment
There was a problem hiding this comment.
Rechecked the main rebase and response-header test fix. The exact-head NOOA suite passes (195 tests); no blocking regression found.
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/38970094312 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/38970605487 |
Tests and validation
Current revision:
069ca4ed6ea6626f08e04ee0cb1fb482d8fe504b. Rebased the existing ten-PR stack onto main9ef5ed0f80a9f81c5d82af6588cd4cc956c4f5d1; assembled tip is196bd5e333abd6e8ee7a93f4c8805ae33f67a66a(#4357).Main compatibility adds only two test updates: #3846 gives the fake HTTP response its headers mapping for checkpoint-aware Environment seeding; #4088 checks serialized tool-output snapshots while retaining history, round-trip, and interpreter-object coverage. Both changes were independently reviewed. The rebase preserves upstream NOOA serialization and runtime configuration changes.
Validation on the exact rebased revisions:
pre-commit run --all-filespassed. DCO sign-offs, sequential layer ancestry, and the focused final diff were checked.Command from each revision's
responses_api_agents/nooa_agent:python -m pytest tests --import-mode=importlib -q -o addopts= -o log_cli=false --tb=short -rs. Exact early-layer tests use installed NOOA051472343211914222e24ce36d8752f4e86bbe43; the assembled tip uses coherent core/CLI/BenchAgent19caab169b018476ac433d040f6ae3f06aeff101. Commands and logs:/tmp/nooa-merge-main-candidate-20261016/final-tests-{3843,3846,3844,4357}/.Prior real-model evidence for the unchanged reviewer-fix behavior remains at
/tmp/nooa-review-fixes-20261016/live-final/, run on pre-rebase tip8185eb1f405ba476aab42b00a222f92dbec4364f: real Qwen output-token and iteration exhaustion each verified once; an actual iteration limit followed by injected cleanup failure remained fatal, skipped verification, and closed both sessions. This main sync adds test compatibility rather than new agent behavior, so that smoke was not rerun and is not presented as a smoke of the rebased tree. It used the integration-test Resources fixture and was not a new SWE-bench/OpenSandbox canary.GitHub CI is requested for the new heads. Optional cross-harness conformance failures also reproduce on main and are separate from the required
Nemo_CICD_Testgate. Existing branch names, bases, draft states, native groups, and description text outside this validation section are preserved.Required branch CI passed on this revision: 8,793 core tests, 921 sandbox tests, 95.07% coverage, and 195 NOOA tests (including Linux installer tests for #3844).
Signed-off-by: Nikhil Deshmudre nikhil.deshmudre@gmail.com