Skip to content

feat(nooa): use standard single-agent-turn sessions - #3846

Merged
init-nikhil merged 1 commit into
init-nikhil/nooa-native-toolsfrom
init-nikhil/nooa-native-sessions
Oct 16, 2026
Merged

init-nikhil merged 1 commit into
init-nikhil/nooa-native-toolsfrom
init-nikhil/nooa-native-sessions

Conversation

@init-nikhil

@init-nikhil init-nikhil commented Oct 1, 2026 •

Copy link
Copy Markdown
Member
  • move NOOA onto Gym’s existing single-agent-turn environment for setup, grading, and cleanup.
  • keep execution in agent sessions so retries reuse the same run instead of executing it twice.
  • use session-provided tool access and return final cookies and observations when closing.
  • let the model recover from tool input errors; skip grading for tool 5xx/connection failures and unrecovered model failures.
  • keep output-token, call, and iteration limits gradable using the partial result.

Tests and validation

Current revision: 069ca4ed6ea6626f08e04ee0cb1fb482d8fe504b. Rebased the existing ten-PR stack onto main 9ef5ed0f80a9f81c5d82af6588cd4cc956c4f5d1; assembled tip is 196bd5e333abd6e8ee7a93f4c8805ae33f67a66a (#4357).

Main compatibility adds only two test updates: #3846 gives the fake HTTP response its headers mapping for checkpoint-aware Environment seeding; #4088 checks serialized tool-output snapshots while retaining history, round-trip, and interpreter-object coverage. Both changes were independently reviewed. The rebase preserves upstream NOOA serialization and runtime configuration changes.

Validation on the exact rebased revisions:

Command from each revision's responses_api_agents/nooa_agent: python -m pytest tests --import-mode=importlib -q -o addopts= -o log_cli=false --tb=short -rs. Exact early-layer tests use installed NOOA 051472343211914222e24ce36d8752f4e86bbe43; the assembled tip uses coherent core/CLI/BenchAgent 19caab169b018476ac433d040f6ae3f06aeff101. Commands and logs: /tmp/nooa-merge-main-candidate-20261016/final-tests-{3843,3846,3844,4357}/.

Prior real-model evidence for the unchanged reviewer-fix behavior remains at /tmp/nooa-review-fixes-20261016/live-final/, run on pre-rebase tip 8185eb1f405ba476aab42b00a222f92dbec4364f: real Qwen output-token and iteration exhaustion each verified once; an actual iteration limit followed by injected cleanup failure remained fatal, skipped verification, and closed both sessions. This main sync adds test compatibility rather than new agent behavior, so that smoke was not rerun and is not presented as a smoke of the rebased tree. It used the integration-test Resources fixture and was not a new SWE-bench/OpenSandbox canary.

GitHub CI is requested for the new heads. Optional cross-harness conformance failures also reproduce on main and are separate from the required Nemo_CICD_Test gate. Existing branch names, bases, draft states, native groups, and description text outside this validation section are preserved.

Required branch CI passed on this revision: 8,793 core tests, 921 sandbox tests, 95.07% coverage, and 195 NOOA tests (including Linux installer tests for #3844).

Signed-off-by: Nikhil Deshmudre nikhil.deshmudre@gmail.com

@init-nikhil init-nikhil added the area:agent Agent harnesses and Responses API agent behavior label Oct 1, 2026
@copy-pr-bot

copy-pr-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@init-nikhil
init-nikhil added this pull request to stack #3852 October 1, 2026 06:39
@init-nikhil
init-nikhil force-pushed the init-nikhil/nooa-native-sessions branch from 86313d0 to 0b49742 Compare October 8, 2026 02:23
@init-nikhil
init-nikhil force-pushed the init-nikhil/nooa-native-sessions branch 2 times, most recently from 1b8b381 to 678ea2b Compare October 9, 2026 21:58
@init-nikhil
init-nikhil removed this pull request from stack #3852 October 9, 2026 21:59
@init-nikhil
init-nikhil added this pull request to stack #4355 October 9, 2026 22:00
@init-nikhil
init-nikhil removed this pull request from stack #4355 October 10, 2026 05:25
@init-nikhil
init-nikhil force-pushed the init-nikhil/nooa-native-sessions branch from 678ea2b to b986f5a Compare October 10, 2026 05:25
@init-nikhil
init-nikhil added this pull request to stack #4367 October 10, 2026 05:25
@init-nikhil init-nikhil changed the title feat(nooa): [wip] adopt native environment-owned sessions feat(nooa): add native sessions and NOOA episode orchestration Oct 10, 2026
@init-nikhil
init-nikhil force-pushed the init-nikhil/nooa-native-sessions branch from b986f5a to 04afd80 Compare October 10, 2026 05:29
@init-nikhil
init-nikhil marked this pull request as ready for review October 12, 2026 04:31
@nemo-automation-bot
nemo-automation-bot Bot requested review from a team October 12, 2026 04:32
@init-nikhil
init-nikhil requested a review from yaoyu-33 October 12, 2026 04:37
@yaoyu-33 yaoyu-33 added complexity:high Cross-component or shared-contract change with a large review surface feature New capabilities, enhancements, or enablement work needs-review PR is ready for code review and waiting on a reviewer labels Oct 12, 2026
@github-actions github-actions Bot added the sla:review-overdue Review response is over the one-business-day SLA label Oct 13, 2026
@init-nikhil
init-nikhil force-pushed the init-nikhil/nooa-native-sessions branch 3 times, most recently from 1fc04d9 to 65b82da Compare October 15, 2026 23:20
@init-nikhil

Copy link
Copy Markdown
Member Author

please don't use "native" terminology - this is really vague and hard to understand. #4070 updated the codebase at the time to move away from this terminology. please do the same here

done, thanks for catching this.

@init-nikhil
init-nikhil requested a review from yaoyu-33 October 15, 2026 23:26
@init-nikhil
init-nikhil force-pushed the init-nikhil/nooa-native-sessions branch 2 times, most recently from 58ac533 to a0392ec Compare October 16, 2026 00:04
@init-nikhil

Copy link
Copy Markdown
Member Author

/ok to test a0392ec

yaoyu-33
yaoyu-33 previously approved these changes Oct 16, 2026

@yaoyu-33 yaoyu-33 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked at 781d07c. Cleanup failures after genuine iteration exhaustion now remain fatal and skip verification; normal limits remain gradable. The exact-head NOOA suite passed: 194 tests. No blocking issue found in this layer; full CI is still outstanding.

@yaoyu-33 yaoyu-33 added ready-to-merge PR is approved, current, and waiting for final CI or merge and removed needs-review PR is ready for code review and waiting on a reviewer labels Oct 16, 2026
@init-nikhil

Copy link
Copy Markdown
Member Author

/ok to test 781d07c

Run one retry-safe NOOA activation per native session. Use the existing
SingleAgentTurnEnvironmentServer for verification, rewards, episode
deadlines and cleanup; return evidence and resource cookies at close.
Remove the NOOA-specific environment, finish endpoint and legacy run
route. Declare the standard environment and example routing explicitly.

Instantiate each runner during agent-session seeding and keep ownership
solely in session state, including reuse on idempotent seed retries.

Return tool HTTP errors outside 5xx as model-visible feedback while
retaining fatal handling for 5xx and transport failures.

Signed-off-by: Nikhil Deshmudre <nikhil.deshmudre@gmail.com>

@yaoyu-33 yaoyu-33 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked the main rebase and response-header test fix. The exact-head NOOA suite passes (195 tests); no blocking regression found.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/38970094312

@github-actions

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/38970605487

This branch was previously deployed

1 inactive deployment
public — 069ca4ed Deployed Oct 16, 2026 by copy-pr-bot[bot] via release / finalize / notify #5693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:agent Agent harnesses and Responses API agent behavior complexity:high Cross-component or shared-contract change with a large review surface feature New capabilities, enhancements, or enablement work ready-to-merge PR is approved, current, and waiting for final CI or merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants