Skip to content

docs(deepagents): fix generic agent launch instructions - #3827

Merged
ananthsub merged 1 commit into
mainfrom
hwolff/deepagent-fix
Oct 6, 2026
Merged

ananthsub merged 1 commit into
mainfrom
hwolff/deepagent-fix

Conversation

@hwolff99

@hwolff99 hwolff99 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR fixes README instructions that caused a launch command to fail configuration validation after changes in using
environment servers.

The old command manually bound the resources server. The new command uses
--agent-type langchain_deepagents_agent.

Checklist

  • I have read the contributing guidelines.
  • The change is focused; unrelated "drive-by" edits are tracked as separate issues/PRs.
  • Tests added or updated and pass locally, or N/A for docs-only / non-code changes (so CI unit/server checks pass when applicable).
  • Documentation added or updated, or N/A with justification.
  • Pre-commit checks pass locally (pre-commit run --all-files) (so CI lint/format checks pass).
  • New source files include the required Apache-2.0 SPDX header.
  • All commits have DCO sign-off (git commit -s) (so the DCO check passes).

Signed-off-by: haydeniw <hwolff@nvidia.com>
@nemo-automation-bot
nemo-automation-bot Bot requested a review from a team October 1, 2026 00:28
@yaoyu-33 yaoyu-33 added area:agent Agent harnesses and Responses API agent behavior complexity:low Localized change in one scope with a small, straightforward review surface docs Documentation-only updates or documentation debt needs-review PR is ready for code review and waiting on a reviewer labels Oct 1, 2026
@github-actions github-actions Bot added the sla:triage-overdue Review assignment is over the one-business-day SLA label Oct 2, 2026
@qiaochuz-nv qiaochuz-nv mentioned this pull request Oct 6, 2026
5 tasks done
@qiaochuz-nv

Copy link
Copy Markdown
Contributor

POR Test Summary — DeepAgents README Launch

Verdict: PASS — documented --agent-type flow validated end to end

The command form documented by this PR was exercised against a clean Gym checkout at a7ca33b:

gym env start --resources-server reasoning_gym --model-type inference_provider --agent-type langchain_deepagents_agent

Observed behavior:

  • The command resolved a healthy 4-server graph: reasoning_gym, the composed DeepAgents instance, its legacy environment server, and policy_model.

  • The bundled simple agent was removed; the existing environment server was repointed to the composed agent.

  • The generic config's resources-server placeholder resolved to reasoning_gym, and model calls routed through policy_model.

  • Static launch validation was clean and emitted no deprecation result.

  • The former --config override was rejected or deprecated, and it failed under strict environment-server enforcement.

  • All 5 original Reasoning Gym inputs produced real trajectories; deterministic verifier replay/controls passed, aggregate mean/reward was 1.0, capture artifacts were complete, and all servers stopped cleanly.

  • QA testcase/check: langchain_deepagents_agent / README --agent-type composition

  • QA run: 20261006T012157814144Z-c47a4502

  • Targeted check duration: 1m 53s

  • Execution: real inference-provider calls; no model stubs, source repair, or reduced dataset

This specifically validates that the README correction selects the intended generic agent composition instead of the stale config-override path.

@ananthsub ananthsub added the r0.7.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. label Oct 6, 2026
@ananthsub
ananthsub enabled auto-merge October 6, 2026 19:08
@ananthsub
ananthsub added this pull request to the merge queue Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/37517405059

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA-NeMo/Gym/actions/runs/37518504361

@github-actions github-actions Bot removed the sla:triage-overdue Review assignment is over the one-business-day SLA label Oct 6, 2026
Merged via the queue into main with commit 366a921 Oct 6, 2026
43 checks passed
@ananthsub
ananthsub deleted the hwolff/deepagent-fix branch October 6, 2026 19:38
ananthsub pushed a commit that referenced this pull request Oct 6, 2026
…into `r0.7.0` (#4126)

beep boop [🤖]: Hi @hwolff99 👋,

    we've cherry picked #3827 into `r0.7.0` for you! 🚀

    Please review and approve this cherry pick by your convenience!

Signed-off-by: haydeniw <hwolff@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: hwolff99 <97551042+hwolff99@users.noreply.github.com>

This branch was previously deployed

1 inactive deployment
public — f59d21bc Deployed Oct 1, 2026 by copy-pr-bot[bot] via release / finalize / notify #4075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:agent Agent harnesses and Responses API agent behavior complexity:low Localized change in one scope with a small, straightforward review surface docs Documentation-only updates or documentation debt needs-review PR is ready for code review and waiting on a reviewer r0.7.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants