Repository navigation
Conversation
Contributor
|
🌿 Preview your docs: https://nvidia-preview-spanev-gdpval-hsg-aav2-workflow.docs.buildwithfern.com/nemo/gym Here are the markdown pages you've updated: |
dznvidia
pushed a commit
that referenced
this pull request
Sep 23, 2026
…dling (#3131) GDPVal comparisons can miss benchmark inputs nested under `reference_files/`, and panel members can be routed through a proxy that fixes the upstream model. This PR adds opt-in recursive input loading and separate GPT, Gemini, and Claude proxies with provider-specific document handling and request limits. - Read nested benchmark inputs, optionally from a validated prepared candidate tree, while keeping submission directories shallow. Both input-reading options remain off by default. - Preserve attachment-omission evidence and enforce image, video-count, and serialized-request limits for each judge. - Allow explicitly listed unfinished candidate tasks to count as audited losses in Stage 1 only. Report actual judged coverage and imputed losses separately; do not reuse imputed losses as cached judgments. - Optionally reassign unavailable references while preserving matchup counts. Missing references never produce automatic wins. The HSG launcher, Office/video/audio preparation, workflow tests, and Slurm guide are split into dependent PR #3550. This core PR does not add cluster scripts or change the reference Elo anchors. Validation: 410 tests passed across the seven core suites, with no skips. Scoped pre-commit and Fern checks passed; Fern's authenticated redirect check was unavailable. No remaining core imports or documentation links depend on the extracted HSG files. Restoring the dependent PR produces the exact original tree at `3d806ab3a`, including file modes; this split changes no implementation behavior. Known limitation: inherited ZIP extraction can still omit oversized members without passing omission markers into the judge request. This split does not resolve that input-fidelity issue. No new live rollout or judging run was launched for the file-only split. --------- Signed-off-by: Serge Panev <spanev@nvidia.com>
Base automatically changed from
spanev/gdpval-checkpoint-e2e-launch-fixes
to
gdpval-devel
September 23, 2026 17:28
5 tasks done
Kh4L
force-pushed
the
spanev/gdpval-hsg-aav2-workflow
branch
from
September 23, 2026 18:40
c4b1475 to
a4e962f
Compare
Keep the launcher, preparation utilities, workflow tests, and guide separate from the core judge fixes. Preserve their original contents and file modes. Signed-off-by: Serge Panev <spanev@nvidia.com>
Kh4L
force-pushed
the
spanev/gdpval-hsg-aav2-workflow
branch
from
September 23, 2026 18:44
a4e962f to
110064d
Compare
7 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides an optional HSG recipe for the existing rollout → preconvert → judge workflow, based directly on
gdpval-devel. Core judge fixes are already merged in #3131.run_aav2.shsubmits each phase separately or imports existing rollouts for fresh judging. Run snapshots preserve the source, dataset, reference paths/Elo anchors, and judging settings.This PR is independent of #3665. It retains its existing local preparation helpers so either PR can merge first. Switching HSG to the shared core helpers is deferred until #3665 merges.
The 20 workflow/test/guide files are unchanged from the original HSG split at
c4b1475b3; only the base has been updated to the mergedgdpval-devel. The scripts retain their HSG filesystem and Slurm/Apptainer assumptions; accounts, images, checkpoint profiles, and reference configurations are supplied externally. No new scheduler or orchestration layer is introduced.Validation: 143 existing workflow tests passed with no skips, including real FFmpeg conversion and local launcher/process fixtures. Repository-wide pre-commit passed. No new live rollout or judging campaign was run for this rebase.
Known limitation: inherited ZIP extraction in judging can omit oversized members without passing omission markers to the judge. This rebase preserves existing behavior.
Checklist
pre-commit run --all-files).git commit -s).