Skip to content

[GDPVal] Add optional HSG rollout, preconvert, and judge workflow - #3550

Draft
Kh4L wants to merge 1 commit into
gdpval-develfrom
spanev/gdpval-hsg-aav2-workflow
Draft

Kh4L wants to merge 1 commit into
gdpval-develfrom
spanev/gdpval-hsg-aav2-workflow

Conversation

@Kh4L

@Kh4L Kh4L commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Provides an optional HSG recipe for the existing rollout → preconvert → judge workflow, based directly on gdpval-devel. Core judge fixes are already merged in #3131.

  • run_aav2.sh submits each phase separately or imports existing rollouts for fresh judging. Run snapshots preserve the source, dataset, reference paths/Elo anchors, and judging settings.
  • Preparation renders Office files, creates H.264 video copies, and losslessly compresses eligible PCM audio. Originals remain untouched; supplied reference caches are reused.
  • Judging enables recursive prepared benchmark inputs, requires usable judgments for all 45 calibration tasks, and reports persisted Stage 1 failures separately from the partial Elo fit.
  • Optional import controls record missing candidate tasks for audited Stage 1 losses, freeze selection seeds, and reassign unavailable references without automatic wins. Empty judge model exports do not override defaults.

This PR is independent of #3665. It retains its existing local preparation helpers so either PR can merge first. Switching HSG to the shared core helpers is deferred until #3665 merges.

The 20 workflow/test/guide files are unchanged from the original HSG split at c4b1475b3; only the base has been updated to the merged gdpval-devel. The scripts retain their HSG filesystem and Slurm/Apptainer assumptions; accounts, images, checkpoint profiles, and reference configurations are supplied externally. No new scheduler or orchestration layer is introduced.

Validation: 143 existing workflow tests passed with no skips, including real FFmpeg conversion and local launcher/process fixtures. Repository-wide pre-commit passed. No new live rollout or judging campaign was run for this rebase.

Known limitation: inherited ZIP extraction in judging can omit oversized members without passing omission markers to the judge. This rebase preserves existing behavior.

Checklist

  • I have read the contributing guidelines.
  • The change is focused; no new workflow behavior is introduced by this rebase.
  • Tests pass locally.
  • Pre-commit checks pass locally (pre-commit run --all-files).
  • All commits have DCO sign-off (git commit -s).

@copy-pr-bot

copy-pr-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown
Contributor

🌿 Preview your docs: https://nvidia-preview-spanev-gdpval-hsg-aav2-workflow.docs.buildwithfern.com/nemo/gym

Here are the markdown pages you've updated:

dznvidia pushed a commit that referenced this pull request Sep 23, 2026
…dling (#3131)

GDPVal comparisons can miss benchmark inputs nested under
`reference_files/`, and panel members can be routed through a proxy that
fixes the upstream model. This PR adds opt-in recursive input loading
and separate GPT, Gemini, and Claude proxies with provider-specific
document handling and request limits.

- Read nested benchmark inputs, optionally from a validated prepared
candidate tree, while keeping submission directories shallow. Both
input-reading options remain off by default.
- Preserve attachment-omission evidence and enforce image, video-count,
and serialized-request limits for each judge.
- Allow explicitly listed unfinished candidate tasks to count as audited
losses in Stage 1 only. Report actual judged coverage and imputed losses
separately; do not reuse imputed losses as cached judgments.
- Optionally reassign unavailable references while preserving matchup
counts. Missing references never produce automatic wins.

The HSG launcher, Office/video/audio preparation, workflow tests, and
Slurm guide are split into dependent PR #3550. This core PR does not add
cluster scripts or change the reference Elo anchors.

Validation: 410 tests passed across the seven core suites, with no
skips. Scoped pre-commit and Fern checks passed; Fern's authenticated
redirect check was unavailable. No remaining core imports or
documentation links depend on the extracted HSG files. Restoring the
dependent PR produces the exact original tree at `3d806ab3a`, including
file modes; this split changes no implementation behavior.

Known limitation: inherited ZIP extraction can still omit oversized
members without passing omission markers into the judge request. This
split does not resolve that input-fidelity issue. No new live rollout or
judging run was launched for the file-only split.

---------

Signed-off-by: Serge Panev <spanev@nvidia.com>
Base automatically changed from spanev/gdpval-checkpoint-e2e-launch-fixes to gdpval-devel September 23, 2026 17:28
@Kh4L Kh4L mentioned this pull request Sep 23, 2026
5 tasks done
@Kh4L
Kh4L force-pushed the spanev/gdpval-hsg-aav2-workflow branch from c4b1475 to a4e962f Compare September 23, 2026 18:40
Keep the launcher, preparation utilities, workflow tests, and guide separate from the core judge fixes. Preserve their original contents and file modes.

Signed-off-by: Serge Panev <spanev@nvidia.com>
@Kh4L
Kh4L force-pushed the spanev/gdpval-hsg-aav2-workflow branch from a4e962f to 110064d Compare September 23, 2026 18:44
@svcnvidia-nemo-ci svcnvidia-nemo-ci added area:evaluation Evaluation, rollout collection, reward profiling, comparison, and exporters feature New capabilities, enhancements, or enablement work labels Oct 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:evaluation Evaluation, rollout collection, reward profiling, comparison, and exporters feature New capabilities, enhancements, or enablement work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants