Repository navigation
fix(openshell): keep generated sandbox names routable - #2671
Merged
Merged
Conversation
Use a compact DNS-safe identifier so current OpenShell gateways accept Gym-created sandboxes without weakening their routing-name constraint. Signed-off-by: Chris Wing <cwing@nvidia.com>
github-actions
Bot
added
the
sla:review-overdue
hemildesai
approved these changes
Aug 24, 2026
github-actions
Bot
removed
the
sla:review-overdue
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ng-<16 hex>OpenShell sandbox names within the gateway's 19-character routing limitALREADY_EXISTSrecoveryFixes #2666.
Test plan
uv run --extra dev --extra openshell pytest tests/unit_tests/test_openshell_provider.py -q(83 passed)pre-commit run --files nemo_gym/sandbox/providers/openshell/provider.py tests/unit_tests/test_openshell_provider.pyAsyncSandboxlifecycle against OpenShell 0.0.111's Homebrew gateway over mTLS: createdng-0a484765a0434088(19 characters), executed a command successfully, and confirmed cleanup with no remaining sandboxes