Repository navigation
test(vllm): cover upstream token metadata fast path - #2174
Closed
jthomson04 wants to merge 1 commit into
Closed
jthomson04 wants to merge 1 commit into
jthomson04 wants to merge 1 commit into
Conversation
Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tokenizefallback is not awaited when native metadata is presentWhy
NeMo-RL can return the exact token metadata already held by its vLLM engine. Gym already supports that response contract and skips its compatibility tokenization request, but the native fast path was not covered directly.
This is intentionally test-only; the existing fallback remains unchanged.
Testing
uv run pytest tests/test_app.py -k preserves_upstream_token_metadata_without_tokenizing -q(1 passed)ruff check tests/test_app.pyruff format --check tests/test_app.pyProducer implementation: NVIDIA-NeMo/RL#3390