Skip to content

[GDPVal] Fix Stirrup reference paths and make head-server wait configurable - #2155

Open
Kh4L wants to merge 2 commits into
mainfrom
spanev/gdpval-stirrup-refpath
Open

Kh4L wants to merge 2 commits into
mainfrom
spanev/gdpval-stirrup-refpath

Conversation

@Kh4L

@Kh4L Kh4L commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

stirrup_agent: reference paths did not match the sandbox

_build_gdpval_user_prompt listed reference files relative to the parent of
input_files_dir, advertising a gdpval_ref_files_<random>/ prefix. Stirrup copies the
contents of that directory into the sandbox working directory, so the prefix does not
exist there. Every reference-bearing task spent ~3 turns on failed ls/cd before
recovering via pwd && ls -la.

Paths are now relative to input_files_dir itself. Adds 3 regression tests covering flat
paths, nested subdirectories, and the no-references case.

scripts/wait_for_servers.sh: hardcoded 60s head-server wait

The phase-1 wait was fixed at 60s. On a Lustre-backed checkout Ray's API server routinely
takes 52-60s to come up — measured at 52s, 52s and 54s across separate runs before one
crossed the line and failed a 4-hour allocation. Now HEAD_MAX_WAIT, default 180s.

Both verified against the real component venv; the 3 new tests pass.

🤖 Generated with Claude Code

Kh4L added 2 commits July 27, 2026 12:13
Signed-off-by: Serge Panev <spanev@nvidia.com>
Signed-off-by: Serge Panev <spanev@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the sla:triage-overdue Review assignment is over the one-business-day SLA label Jul 28, 2026
@anwithk
anwithk requested a review from agronskiy July 29, 2026 16:40
@github-actions github-actions Bot added sla:review-overdue Review response is over the one-business-day SLA and removed sla:triage-overdue Review assignment is over the one-business-day SLA labels Jul 29, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added area:agent Agent harnesses and Responses API agent behavior bug Something isn't working needs-review PR is ready for code review and waiting on a reviewer labels Oct 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:agent Agent harnesses and Responses API agent behavior bug Something isn't working needs-review PR is ready for code review and waiting on a reviewer sla:review-overdue Review response is over the one-business-day SLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants