Repository navigation
feat: provider neutral cvdp sandbox update - #2076
Merged
Merged
Conversation
Signed-off-by: Christian Munley <cmunley@nvidia.com>
cmunley1
marked this pull request as ready for review
July 18, 2026 19:38
github-actions
Bot
added
the
sla:triage-overdue
arti4nvj
reviewed
Jul 21, 2026
| cwd=wd, | ||
| timeout_s=self.config.timeout, | ||
| ) | ||
| if agent_result.return_code != 0: |
Contributor
There was a problem hiding this comment.
This will cause the entire rollouts collection to stop right? Is there a reason this design to stop the entire process is better than having it score 0 and continue on?
arti4nvj
reviewed
Jul 21, 2026
| ) | ||
| ) | ||
| await box.download(f"{traj}/response.json", resp_local) | ||
| response = NeMoGymResponse.model_validate_json(resp_local.read_text()) |
Contributor
There was a problem hiding this comment.
same point as before, if there's no response.json, the whole thing will fail rather than scoring a 0 right
arti4nvj
reviewed
Jul 21, 2026
| @@ -142,7 +116,7 @@ anthropic_base_url: https://api.anthropic.com | |||
| cvdp_sim_image: nvidia/cvdp-sim:v1.0.0 | |||
Contributor
There was a problem hiding this comment.
can we add update to read me that says:
Bare refs must be pullable from a registry (docker://...) or local-only images must use an explicit .sif path.
github-actions
Bot
removed
the
sla:triage-overdue
Contributor
Author
|
/claude review |
arti4nvj
previously approved these changes
Aug 7, 2026
cmunley1
changed the title
Signed-off-by: Christian Munley <cmunley@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.