Repository navigation
feat: unify judge failures in Gym benchmarks - #2044
Closed
e-dobrowolska wants to merge 2 commits into
Closed
e-dobrowolska wants to merge 2 commits into
e-dobrowolska wants to merge 2 commits into
Conversation
Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
8 tasks
Contributor
|
Thank you for doing the original cross-benchmark judge audit and implementation. The shared helper and broad inventory informed merged #2113. This draft is now superseded by #2113 for the current helper and #3180 for migration away from reward-zero failure sentinels under the typed #2135/#2608 contracts. Closing this PR avoids two competing judge-failure designs while preserving its tests and server inventory as implementation evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize judge-failure recording across all LLM-as-judge benchmarks
Adds a shared abstraction (
nemo_gym/judge.py) so a failed judge call (auth, rate-limit, timeout, HTTP, empty/malformed response) is recorded as a distinct outcome instead of being silently scored as a wrong answer:JudgeFailureMixin— standard per-sample fields judge_failed + judge_failure_reason (raw error), identical across benchmarks.run_judge()— wraps a judge call, catching failures instead of raising or defaulting to 0.judge_failure_metrics()— emits judge_failures (count), mean/judge_failed (rate), and two accuracy views: the usual one (failures = 0) and reward[judge_ok_only] (failures excluded), so a broken judge can't silently deflate scores.Scope: applied to all 27 judge-based benchmarks (25 directly + physics_judge/math_with_autograder via inheritance), each with a wiring test.