Skip to content

feat: unify judge failures in Gym benchmarks - #2044

Closed
e-dobrowolska wants to merge 2 commits into
mainfrom
edobrowolska/judge_failures_clean
Closed

e-dobrowolska wants to merge 2 commits into
mainfrom
edobrowolska/judge_failures_clean

Conversation

@e-dobrowolska

Copy link
Copy Markdown
Contributor

Standardize judge-failure recording across all LLM-as-judge benchmarks

Adds a shared abstraction (nemo_gym/judge.py) so a failed judge call (auth, rate-limit, timeout, HTTP, empty/malformed response) is recorded as a distinct outcome instead of being silently scored as a wrong answer:

  • JudgeFailureMixin — standard per-sample fields judge_failed + judge_failure_reason (raw error), identical across benchmarks.
  • run_judge() — wraps a judge call, catching failures instead of raising or defaulting to 0.
  • judge_failure_metrics() — emits judge_failures (count), mean/judge_failed (rate), and two accuracy views: the usual one (failures = 0) and reward[judge_ok_only] (failures excluded), so a broken judge can't silently deflate scores.

Scope: applied to all 27 judge-based benchmarks (25 directly + physics_judge/math_with_autograder via inheritance), each with a wiring test.

Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ananthsub

Copy link
Copy Markdown
Contributor

Thank you for doing the original cross-benchmark judge audit and implementation. The shared helper and broad inventory informed merged #2113. This draft is now superseded by #2113 for the current helper and #3180 for migration away from reward-zero failure sentinels under the typed #2135/#2608 contracts. Closing this PR avoids two competing judge-failure designs while preserving its tests and server inventory as implementation evidence.

@ananthsub ananthsub closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants