Repository navigation
Longmt thread safe - #1961
Merged
Merged
Longmt thread safe#1961
Conversation
Signed-off-by: Brian Thompson <3534106+thompsonb@users.noreply.github.com>
…skipped because the packages required for them are in the actor venv, not the main venv. Agent downloads are now thread-safe, so this is no longer needed Signed-off-by: Brian Thompson <3534106+thompsonb@users.noreply.github.com>
Signed-off-by: Brian Thompson <3534106+thompsonb@users.noreply.github.com>
Signed-off-by: Brian Thompson <3534106+thompsonb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _prefetch_judge_models() functions in benchmarks/longmt_pg19/prepare.py and benchmarks/longmt_wmt24pp/prepare.py were intended to pre-fetch models (comet, laser2, and ersatz) before agents were fanned out because those agents perform downloads which are not threadsafe. However, the venv that _prefetch_judge_models() is called from does not match that of the agents, causing the pre-fetch to fail and the subsequent downloads to collide.
The agent venv is already fragile and I did not believe it was a good idea to duplicate those requirements across a second venv, potentially conflicting with existing requirements.
Instead, I removed the _prefetch_judge_models() functions and added protection around each download within the agent code to prevent collision.
I also added defaults for two environment variables (LASER_HOME, ERSATZ) in the agent environment only. A missing LASER_HOME in particular caused the code to crash.