Repository navigation
fix: loose accuracy in ifbench scorer - #1936
Merged
Merged
Conversation
Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
e-dobrowolska
force-pushed
the
edobrowolska/ifbench_scorer
branch
from
July 6, 2026 14:52
965ed52 to
0ccb4a8
Compare
gwarmstrong
previously approved these changes
Jul 6, 2026
gwarmstrong
left a comment
gwarmstrong
left a comment
Contributor
There was a problem hiding this comment.
LGTM, non-blocking comment to include some test coverage of the new flags
ananthsub
reviewed
Jul 6, 2026
Signed-off-by: Ewa Dobrowolska <edobrowolska@nvidia.com>
gwarmstrong
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Gym reports only strict accuracy for ifbench. This PR intoduces a loose accuracy or ifbench (in addition to the strict accuracy)