Repository navigation
Add sandbox coverage unit tests - #1684
Merged
cmunley1 merged 1 commit intoJun 23, 2026
Merged
Conversation
Signed-off-by: Hemil Desai <hemild@nvidia.com>
cmunley1
approved these changes
Jun 23, 2026
ritaneves
pushed a commit
that referenced
this pull request
Jun 25, 2026
## Summary - add OpenSandbox provider tests for extension validation, float resource normalization, and retry-loop guard branches - add public sandbox/registry tests for missing-spec status, builtin provider loading, and sync async-operation timeouts - raises focused sandbox coverage from 98.34% to 99.86%, leaving only an unreachable defensive OpenSandbox create fallback uncovered ## Validation - `UV_CACHE_DIR=/tmp/uv-cache uv run pre-commit run --files tests/unit_tests/test_opensandbox_provider.py tests/unit_tests/test_sandbox.py` - `UV_CACHE_DIR=/tmp/uv-cache uv run pytest tests/unit_tests/test_opensandbox_provider.py tests/unit_tests/test_sandbox.py --cov=nemo_gym.sandbox.providers.opensandbox --cov=nemo_gym.sandbox.providers.registry --cov=nemo_gym.sandbox.api --cov-report=term-missing` - `UV_CACHE_DIR=/tmp/uv-cache uv run pytest tests/unit_tests/ -x` Signed-off-by: Hemil Desai <hemild@nvidia.com> Signed-off-by: Rita Fernandes Neves <rfernandesne@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
UV_CACHE_DIR=/tmp/uv-cache uv run pre-commit run --files tests/unit_tests/test_opensandbox_provider.py tests/unit_tests/test_sandbox.pyUV_CACHE_DIR=/tmp/uv-cache uv run pytest tests/unit_tests/test_opensandbox_provider.py tests/unit_tests/test_sandbox.py --cov=nemo_gym.sandbox.providers.opensandbox --cov=nemo_gym.sandbox.providers.registry --cov=nemo_gym.sandbox.api --cov-report=term-missingUV_CACHE_DIR=/tmp/uv-cache uv run pytest tests/unit_tests/ -x