Skip to content

feat: ether0 environment - #1472

Merged
cmunley1 merged 3 commits into
mainfrom
cmunley1/ether0-env
Jun 24, 2026
Merged

cmunley1 merged 3 commits into
mainfrom
cmunley1/ether0-env

Conversation

@cmunley1

Copy link
Copy Markdown
Contributor

move ether0 environment to environments/

Signed-off-by: Christian Munley <cmunley@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented May 30, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@marta-sd
marta-sd self-requested a review June 15, 2026 09:19
Start servers and collect rollouts
```bash
# start vllm and nemo gym servers
vllm serve futurehouse/ether0 &

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know which vllm version should be used here? I tried with the latest (0.23) and the model outputs gibberish

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or more broadly: these deployment command does not work for me. Either wrong vllm version or I'm missing some flags/sampling params.

"output": [
      {
        "id": "msg_0ab03270a5c14a83b3376726beb2d792",
        "content": [
          {
            "annotations": [],
            "text": "<|think_start|>Okay,Ġlet'sĠsee.ĠIĠneedĠtoĠfigureĠoutĠwhichĠofĠtheseĠthreeĠmoleculesĠhasĠanĠoralĠLD50ĠinĠratsĠofĠ6.09Ġmg/kg.ĠLD50ĠisĠtheĠlethalĠdoseĠthatĠkillsĠ50%ĠofĠtheĠtestĠsubjects,ĠsoĠaĠlowerĠLD50ĠmeansĠtheĠcompoundĠisĠmoreĠtoxic.Ġ6.09Ġmg/kgĠisĠaĠprettyĠlowĠvalue,ĠsoĠtheĠcompoundĠisĠquiteĠtoxic.ĊĊFirst,Ġlet'sĠlookĠatĠtheĠstructuresĠofĠtheĠgivenĠmolecules:ĊĊ1.Ġ**FirstĠmolecule:ĠC(CS)(=O)O**ĊĠĠĠ-ĠThisĠisĠaĠthioetherĠderivativeĠofĠaĠcarboxylicĠacid,ĠsimilarĠtoĠthioetherĠderivativesĠofĠaceticĠacid.ĠThioethersĠcanĠbeĠtoxic,ĠbutĠtheirĠLD50ĠisĠtypicallyĠaroundĠ100âĢĵ500Ġmg/kg.ĊĊ2.Ġ**SecondĠmolecule:ĠC(O)CNFCC(=O)OClCC(=O)O**ĊĠĠĠ-ĠThisĠisĠaĠcomplexĠstructureĠwithĠaĠmorpholine-likeĠringĠandĠesterĠgroups,ĠsimilarĠtoĠaĠphosgeneĠderivative.ĠPhosgeneĠisĠhighlyĠtoxic,ĠandĠitsĠoralĠLD50ĠinĠratsĠisĠaroundĠ6âĢĵ8Ġmg/kg.ĊĊ3.Ġ**ThirdĠmolecule:ĠC(O)CNFCC(=O)OClCC(=O)O**ĊĠĠĠ-ĠThisĠisĠaĠcomplexĠstructureĠwithĠaĠmorpholine-likeĠringĠandĠesterĠgroups,ĠsimilarĠtoĠaĠphosgeneĠderivative.ĠPhosgeneĠisĠhighlyĠtoxic,ĠandĠitsĠoralĠLD50ĠinĠratsĠisĠaroundĠ6âĢĵ8Ġmg/kg.ĊĊComparingĠtheĠoptions,ĠtheĠsecondĠmoleculeĠisĠtheĠmostĠlikelyĠtoĠhaveĠanĠoralĠLD50ĠofĠ6.09Ġmg/kg.<|think_end|><|answer_start|>C(O)CNFCC(=O)OClCC(=O)O<|answer_end|>",
            "type": "output_text",
            "logprobs": null
          }
        ],
        "role": "assistant",
        "status": "completed",
        "type": "message"
      }
    ],

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for raising this, i think we should open an issue or just revisit this soon, for now the goal of this PR is to just migrate the environment config, instructions, data prep to the new environments dir rather than fix things. This worked last time i tested, so it must be vllm version or something

Comment thread environments/ether0/prepare.py Resolved
@cmunley1
cmunley1 merged commit fdd6130 into main Jun 24, 2026
15 checks passed
@cmunley1
cmunley1 deleted the cmunley1/ether0-env branch June 24, 2026 00:08
ritaneves pushed a commit that referenced this pull request Jun 25, 2026
move ether0 environment to environments/

Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Rita Fernandes Neves <rfernandesne@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants