-
Notifications
You must be signed in to change notification settings - Fork 268
Full Resumability PR 1: Create DAG #1994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oyilmaz-nvidia
wants to merge
8
commits into
NVIDIA-NeMo:main
Choose a base branch
from
oyilmaz-nvidia:onur/parent-children-lmdb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c1eb896
Add unique and deterministic id generation
oyilmaz-nvidia 1b9a771
Create DAG by adding parents and children tasks
oyilmaz-nvidia 44b38bb
Fix linting issue
oyilmaz-nvidia eaaf4f5
Adding lmdb
oyilmaz-nvidia 483eb9e
Do not assign _udid if it's already set
oyilmaz-nvidia b3968c6
Prevent loop by adding same task as parent or child
oyilmaz-nvidia f806a55
Cover initial task _udid
oyilmaz-nvidia c67922b
Get unique id update
oyilmaz-nvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_if_exists=Truesilently reuses an actor with a different checkpoint pathIf a
LineageWriterActorfrom a previous pipeline run is still alive,get_if_exists=Truereturns the existing actor without calling its constructor — meaning thepath=absolute_checkpoint_pathargument is silently ignored and the new run writes lineage into the old file. The same pattern appears inray_data/executor.pyandxenna/executor.py. Consider using a run-scoped unique actor name or validating the returned actor's path.