Skip to content

.NET 5.0 removes SpanId and ActivityId #445

Description

@snakefoot

ActivityId has been removed as default outer-scope-property. Instead it is injected using LoggerExternalScopeProvider:

dotnet/runtime#34305
dotnet/runtime#37092

Because NLog doesn't make use of LoggerExternalScopeProvider, then NLog might have to implements its own logic to check ActivityTrackingOptions. Alternative just rely on the layout-renderer from NLog.DiagnosticSource.

Also notice that .NET 5 adds implicit dependency from Microsoft.Extensions.Logging to System.Diagnostics.DiagnosticSource:

https://www.nuget.org/packages/Microsoft.Extensions.Logging

So one could merge NLog.Extensions.Logging together with NLog.DiagnosticSource

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions