Skip to content

Add dry-run mode to update-index - #76

Open
shin4141 wants to merge 1 commit into
NII-cloud-operation:mainfrom
shin4141:codex/issue-9-update-index-dry-run
Open

shin4141 wants to merge 1 commit into
NII-cloud-operation:mainfrom
shin4141:codex/issue-9-update-index-dry-run

Conversation

@shin4141

Copy link
Copy Markdown

Summary

  • Add --dry-run to jupyter nbsearch update-index.
  • Reuse the existing notebook selection and filtering logic, then print selected relative notebook paths in deterministic order.
  • Exit before notebook parsing or any Solr/S3 write.

Compatibility boundaries

  • Dry-run still loads the existing Python config, matching normal update-index behavior.
  • Existing basename-only matching for an explicit path is intentionally preserved.
  • Selected paths are written to stdout; diagnostics remain on stderr.

Tests

  • python -m unittest nbsearch.tests.test_update_index -v (8 tests passed)
  • python -m unittest discover nbsearch.tests -v (22 tests passed)

Fixes #9

@github-actions

Copy link
Copy Markdown

Binder 👈 Launch a Binder on branch shin4141/nbsearch/codex/issue-9-update-index-dry-run

@shin4141
shin4141 marked this pull request as ready for review August 20, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: update-index dry-run mode

1 participant